Set hstart to timestep #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K20shores
requested review from
sjsprecious,
montythind,
mattldawson,
boulderdaze and
mwaxmonsky
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 53 53
Lines 3586 3586
=======================================
Hits 3342 3342
Misses 244 244 ☔ View full report in Codecov by Sentry. |
sjsprecious
approved these changes
Oct 18, 2024
mwaxmonsky
approved these changes
Oct 18, 2024
boulderdaze
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easy to test backward euler in the performance repository, I've added
h_startto the backward euler parameters. This means we can use the same testing code for rosenbrock or backward euler