Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding icon to readme and favicon to docs #298

Merged
merged 5 commits into from
Oct 16, 2023
Merged

adding icon to readme and favicon to docs #298

merged 5 commits into from
Oct 16, 2023

Conversation

K20shores
Copy link
Collaborator

@K20shores K20shores commented Oct 11, 2023

I made a favicon which is just the letter M with the little molecule behind it. I also added the micm image which has the molecule, "MICM", and the microchip as an image for the readme. All of the SVGs for this are saved in our musica drive -> software development plans -> musica -> musica graphics -> micm

Docs here. You should be able to see the favicon in the tab bar of your browser

@K20shores K20shores requested a review from mattldawson October 11, 2023 15:32
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (688fdae) 96.98% compared to head (b159f66) 96.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          34       34           
  Lines        2683     2683           
=======================================
  Hits         2602     2602           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Are there any licensing things to consider with the images?

@K20shores
Copy link
Collaborator Author

I like it! Are there any licensing things to consider with the images?

All of the SVGs I used are licensed under creative commons 0 and we are free to modify or distribute and no attribution is required.

@K20shores K20shores merged commit 356a3e5 into main Oct 16, 2023
58 checks passed
@K20shores K20shores deleted the favicon branch October 16, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants