Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a StateParameters data member in the State class #687

Open
sjsprecious opened this issue Nov 13, 2024 · 0 comments
Open

Add a StateParameters data member in the State class #687

sjsprecious opened this issue Nov 13, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
MICM Paper

Comments

@sjsprecious
Copy link
Collaborator

In the PR #668, many data members of the State class are just a copy of the data from the StateParameters.

It may be better to create a data member of type StateParameters in the State class instead and use std::move during the initialization later.
@sjsprecious sjsprecious added the enhancement New feature or request label Nov 13, 2024
@sjsprecious sjsprecious added this to the MICM Paper milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
MICM Paper
Development

No branches or pull requests
1 participant
@sjsprecious