New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jacobian diagonal elements should be moved to the state #681

Open

K20shores opened this issue Oct 22, 2024 · 0 comments

Labels

bug

Milestone

MICM, TUV-x in CA...

Collaborator

K20shores commented Oct 22, 2024

During #668, I noticed that the jacobian diagonal elements are still on the solver and so we are not yet agnostic to the mechanism solved

micm/include/micm/solver/rosenbrock.hpp

Line 57 in 3f0c607

std::vector<std::size_t> jacobian_diagonal_elements_;

Acceptance criteria

jacobian diagonal elements are removed from the solver

K20shores added the bug label

K20shores added this to the MICM, TUV-x in CAM-SIMA milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment