Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update update_cloudfront resource count conditional #166

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

botanical
Copy link
Member

@botanical botanical commented Jun 13, 2024

Summary: Summary of changes

Addresses VEDA-164: Develop amazing new feature

When trying to deploy with cloudfront_id set, I got this error:

╷
│ Error: Incorrect condition type
│ 
│   on main.tf line 275, in resource "null_resource" "update_cloudfront":
│  275:   count = coalesce(var.cloudfront_id, false) ? 1 : 0
│     ├────────────────
│     │ var.cloudfront_id is "redacted"
│ 
│ The condition expression must be of type bool.
╵

    }

Changes

  • Update count conditional so that the expression is of type bool

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@botanical
Copy link
Member Author

Would we prefer the secret name to be CLOUDFRONT_ID or VEDA_CLOUDFRONT_ID?

@anayeaye anayeaye self-requested a review June 14, 2024 14:48
@anayeaye
Copy link
Contributor

Would we prefer the secret name to be CLOUDFRONT_ID or VEDA_CLOUDFRONT_ID?

In veda-deploy VEDA_ is prefixed to the variables parsed from cdk.out in scripts/generate_env_file.py so I think we should expect VEDA_ in tfvars for now?

@botanical botanical merged commit ccbfba9 into dev Jun 14, 2024
3 checks passed
@botanical botanical deleted the jt/fix-update-cloudfront branch June 14, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants