Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] Initial Hog Farm Push #380

Merged
merged 199 commits into from
Oct 29, 2024
Merged

[Content] Initial Hog Farm Push #380

merged 199 commits into from
Oct 29, 2024

Conversation

WeathermanTrent
Copy link
Collaborator

@WeathermanTrent WeathermanTrent commented Apr 15, 2024

Pull Request Contents

  1. New story - 'North Carolina Hog Farms'
  2. Removed old EPA datasets and directed their use from the GHGC STAC
  3. Updated and standardized topic tags on all existing stories and datasets
  4. Updated data visualization zoom extents in some existing stories where map zoom was not set
  5. Added GeoHealth paper citation to HMA heat stress and AOD stories, and changed disclaimer on burn scar story to note a paper is in progress (and added thesis citation to burn scar - will replace with paper citation when published)
  6. Minor prose edits in dataset landing pages to clean them up (bigger standardization effort will come later)
  7. Clarified obscure dataset names
  8. Used internal style for linking to stories from other data story pages
  9. Standardized disclaimer for community contributed stories

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 4b4a238
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6716b1716797430009265384
😎 Deploy Preview https://deploy-preview-380--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

changed peer-review warning label to say "Data Story" rather than "Discovery"
Added the <Link to= {"/stories/story-indicator"]>text</Link> to route internal link to existing Houston AOD data story
Updated formatting ...
Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerikac just confirmed

that the NC-Hogs VEDA data story PR is ready to be merged into Prod (the NLCD PR is not a blocker)

NB: The PR changes a lot of files besides that one story. Mostly adding taxonomy to many existing datasets and stories and removing (or replacing?) EPA datasets.

These changes are should be acknowledge in the PR description.

@j08lue j08lue requested review from slesaad and removed request for slesaad October 17, 2024 13:24
.env Outdated Show resolved Hide resolved
Copy link
Collaborator

@freitagb freitagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other areas where my comments here apply but i didn't want to do a bunch of copy/pastes.

.env Outdated Show resolved Hide resolved
datasets/cmip6-tas.data.mdx Outdated Show resolved Hide resolved
- Climate Model
- name: Source
values:
- NASA EIS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the dataset overview pages we have inconsistencies where provider is included as a source. Does EIS want a tag for their group in the dataset config file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are currently >20 datasets in the dashboard catalog with NASA EIS Values tags, so I will not change these until we confirm if they want a tag or not.

datasets/cmip6-tas.data.mdx Outdated Show resolved Hide resolved
@@ -26,7 +31,7 @@ infoDescription: |
layers:
- id: combined_CMIP6_daily_GISS-E2-1-G_tas_kerchunk_DEMO
stacCol: combined_CMIP6_daily_GISS-E2-1-G_tas_kerchunk_DEMO
name: CMIP6 Daily GISS-E2-1-G Near-Surface Air Temperature (demo subset)
name: CMIP6 Daily GISS-E2-1-G Near-Surface Air Temperature (demo subset; 1950-2014)
type: zarr
tileApiEndpoint: 'https://prod-titiler-xarray.delta-backend.com/tilejson.json'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on timeline for titiler-xarray deployment we'll need to update these endpoints.

@@ -11,7 +11,15 @@ media:
taxonomy:
- name: Topics
values:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who suggested these topics? They're all over the map in specificity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe EIS has a list they required we include.

@@ -19,6 +19,10 @@ taxonomy:
- name: Topics
values:
- Water Quality
- name: Source
values:
- Oregon State University
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another provider in the source list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who would the Source be for this dataset then?

- COVID 19
- name: Source
values:
- Black Marble
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't the best source need something better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you suggest? We struggled to find a good source tag for this.

datasets/ps_blue_tarp_detections.ej.data.mdx Outdated Show resolved Hide resolved
@@ -11,7 +11,14 @@ media:
taxonomy:
- name: Topics
values:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did topic values here come from. Much more specific that others which leads to inaccurate/confusing faceted search results.

Copy link
Collaborator

@freitagb freitagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look good to me.

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the reviews and have the impression that all comments have been addressed. 👌

@aboydnw
Copy link
Contributor

aboydnw commented Oct 29, 2024

@acblackford if you're ready, go ahead and merge
@snmln @hanbyul-here let's include this in the release today if possible

@acblackford acblackford merged commit 38b8616 into develop Oct 29, 2024
6 checks passed
@acblackford acblackford deleted the nc-hogs branch October 29, 2024 16:49
@acblackford
Copy link
Contributor

@snmln @hanbyul-here why was this not included in the release yesterday?

@aboydnw
Copy link
Contributor

aboydnw commented Oct 30, 2024

@acblackford we haven't released veda-config yet, we'll post a message in slack when we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants