-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content] Initial Hog Farm Push #380
Conversation
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
changed peer-review warning label to say "Data Story" rather than "Discovery"
Added the <Link to= {"/stories/story-indicator"]>text</Link> to route internal link to existing Houston AOD data story
Updated formatting ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerikac just confirmed
that the NC-Hogs VEDA data story PR is ready to be merged into Prod (the NLCD PR is not a blocker)
NB: The PR changes a lot of files besides that one story. Mostly adding taxonomy to many existing datasets and stories and removing (or replacing?) EPA datasets.
These changes are should be acknowledge in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other areas where my comments here apply but i didn't want to do a bunch of copy/pastes.
- Climate Model | ||
- name: Source | ||
values: | ||
- NASA EIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the dataset overview pages we have inconsistencies where provider is included as a source. Does EIS want a tag for their group in the dataset config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are currently >20 datasets in the dashboard catalog with NASA EIS Values tags, so I will not change these until we confirm if they want a tag or not.
@@ -26,7 +31,7 @@ infoDescription: | | |||
layers: | |||
- id: combined_CMIP6_daily_GISS-E2-1-G_tas_kerchunk_DEMO | |||
stacCol: combined_CMIP6_daily_GISS-E2-1-G_tas_kerchunk_DEMO | |||
name: CMIP6 Daily GISS-E2-1-G Near-Surface Air Temperature (demo subset) | |||
name: CMIP6 Daily GISS-E2-1-G Near-Surface Air Temperature (demo subset; 1950-2014) | |||
type: zarr | |||
tileApiEndpoint: 'https://prod-titiler-xarray.delta-backend.com/tilejson.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on timeline for titiler-xarray deployment we'll need to update these endpoints.
@@ -11,7 +11,15 @@ media: | |||
taxonomy: | |||
- name: Topics | |||
values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who suggested these topics? They're all over the map in specificity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe EIS has a list they required we include.
@@ -19,6 +19,10 @@ taxonomy: | |||
- name: Topics | |||
values: | |||
- Water Quality | |||
- name: Source | |||
values: | |||
- Oregon State University |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another provider in the source list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who would the Source be for this dataset then?
- COVID 19 | ||
- name: Source | ||
values: | ||
- Black Marble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't the best source
need something better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you suggest? We struggled to find a good source tag for this.
@@ -11,7 +11,14 @@ media: | |||
taxonomy: | |||
- name: Topics | |||
values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where did topic values here come from. Much more specific that others which leads to inaccurate/confusing faceted search results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the reviews and have the impression that all comments have been addressed. 👌
@acblackford if you're ready, go ahead and merge |
@snmln @hanbyul-here why was this not included in the release yesterday? |
@acblackford we haven't released veda-config yet, we'll post a message in slack when we do. |
Pull Request Contents