Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JPL CoreFSW Variable References #1261

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

goetzrrGit
Copy link
Contributor

Description

To address compatibility issues between coreFSW's variable references and SeqCore/SeqAdaptation, I've introduced a dedicated function within eDSL. This function seamlessly converts local/parameter variables from a symbol into a string within the SeqJSON, enabling downstream processing by the SeqAdaptation.

Converting from SeqJSON back to eDSL can lead to ambiguity regarding the use of reference variables as command arguments. An error message is generated that the user will need to resolve.

  Sequence.new({
    seqId: 'banana00001.0000a',
    metadata: {
      onboard_name: 'test.mod',
      onboard_path: '/eng',
      other_arbitrary_metadata: 'test_metadata',
    },
    locals: [
      UINT('LOOINT')
    ],
    steps: ({ locals, parameters }) => ([
      C.PREHEAT_OVEN(
      REF(locals.LOOINT) --> "VERIFY: 'locals.LOOINT' is a Variable References"
      ),
    ]),
  });

Verification

updated and ran the e2e test

@goetzrrGit goetzrrGit requested a review from a team as a code owner December 19, 2023 20:38
@goetzrrGit goetzrrGit changed the title Support JPL coreFSW Variable References Support JPL CoreFSW Variable References Dec 19, 2023
@goetzrrGit goetzrrGit added sequencing Anything related to the sequencing domain feature A new feature or feature request clipper Requests from the Europa Clipper project labels Jan 8, 2024
Copy link
Contributor

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, code makes sense and the presentation we walked through gave the background.

Due to limitations in the eDSL, reference variables utilized by JPLs coreFSW weren't directly supported. Existing tools like SeqGen and SeqAdaption addressed this gap with a workaround. I've implemented functionality within the eDSL to enable creation of reference variables that is very specific to JPLs downstream tools.
@goetzrrGit goetzrrGit force-pushed the eDSL_variable_reference branch from 5ef18c0 to cdfeecb Compare January 17, 2024 18:46
@goetzrrGit goetzrrGit merged commit f6dd79f into develop Jan 17, 2024
6 checks passed
@goetzrrGit goetzrrGit deleted the eDSL_variable_reference branch January 17, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clipper Requests from the Europa Clipper project feature A new feature or feature request sequencing Anything related to the sequencing domain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Variable References in eDSL
2 participants