Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snapshot Tags, Description #1147

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

Mythicaeda
Copy link
Contributor

Description

Adds new metadata to Plan Snapshots: Tags, Description
Adds new metadata to Plan: Description

Adds Hasura relationship from Snapshots to their Activities and Tags

Verification

Spun up Aerie and checked that the metadata was correct in Hasura.

Documentation

Future work

The UI has a ticket for allowing Plan Metadata to be updated. The description column needs to be added to that list.

@Mythicaeda Mythicaeda added feature A new feature or feature request database Anything related to the database labels Sep 14, 2023
@Mythicaeda Mythicaeda self-assigned this Sep 14, 2023
@Mythicaeda Mythicaeda requested a review from a team as a code owner September 14, 2023 22:53
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 14, 2023 22:53 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 14, 2023 22:53 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 14, 2023 22:53 — with GitHub Actions Inactive
Copy link
Contributor

@skovati skovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just some non-blocking questions / comments. Nice work 🚀

@Mythicaeda Mythicaeda force-pushed the feat/add-snapshot-tags-description branch from 91d5958 to b5a8546 Compare September 19, 2023 16:33
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 19, 2023 16:33 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 19, 2023 16:33 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 19, 2023 16:33 — with GitHub Actions Inactive
- add description column
- add association table "plan_snapshot_tags"
@Mythicaeda Mythicaeda force-pushed the feat/add-snapshot-tags-description branch from b5a8546 to a52dd6b Compare September 19, 2023 16:49
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 19, 2023 16:49 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 19, 2023 16:49 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 19, 2023 16:49 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda merged commit 66404a8 into develop Sep 19, 2023
10 checks passed
@Mythicaeda Mythicaeda deleted the feat/add-snapshot-tags-description branch September 19, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Anything related to the database feature A new feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a description and tags to Snapshots
2 participants