Validate User Role Permissions JSONs #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
added
refactor
This will make it easier to maintain vs having the roles created and assigned permissions across multiple files
Mythicaeda
force-pushed
the
feat/validate-urp-json
branch
from
6ce4b8f to
b528aec
Compare
Mythicaeda
force-pushed
the
feat/validate-urp-json
branch
from
b528aec to
100261b
Compare
Mythicaeda
commented
Sep 25, 2023
Mythicaeda
force-pushed
the
feat/validate-urp-json
branch
from
100261b to
799c0ef
Compare
adrienmaillard
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A trigger was added to the
user_role_permissiontable that checks if all the keys and permissions are actual Keys and Permissions. For Permissions, there is an additional check that Plan Merge Permissions are only applied to Plan Merge Functions.Additionally, we were creating all the preloaded users/user-roles across several files. They've been moved to a single file:
default_user_roles.sqlVerification
New Permissions DB tests were added
Documentation
No documentation changes are necessary
Future work