Feature/seq editor cleanup #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
21a25ae to
7cf09ab
Compare
AaronPlave
reviewed
Jun 20, 2024
AaronPlave
reviewed
Jun 20, 2024
AaronPlave
reviewed
Jun 20, 2024
AaronPlave
reviewed
Jun 20, 2024
AaronPlave
reviewed
Jun 20, 2024
AaronPlave
reviewed
Jun 20, 2024
|
Missing this item from the in progress list:
|
I added this empty state to the selected command editor, unless this isn't what you were referencing?
|
Ah I see, have to select a parcel first, thanks. Could you add |
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
a3525b4 to
ed28edb
Compare
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
ed28edb to
08413cd
Compare
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
08413cd to
7709156
Compare
* Moved to a more general seq editor and adaptation * Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time * Fix plan metadata name input reset on snapshot preview (#1358) * fix table action icons staying disabled when no longer in snapshot preview * make table components less plan specific * Add plan JSON export (#1357) * add plan JSON export * Hide plan export button (#1374) * Release v2.15.0 (#1377) Co-authored-by: joswig <[email protected]> * Cleanup NumEditor and convert value to a number Added tooltip support for repeat args Removed utils.ts again Cleaned up DictionaryTable so theres only one selection type now Cleaned up dictionary permissions Removed aerie-phoenix-wordmark Disable seqn and seqjson exports when there is no sequence Added styles to the selected command section Converted fswCommandArgDefault to use a switch Renamed parcel to parameter dictionaries Some more cleanup Fixed toggling by clicking a row on the parcel page Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument Added st-typography-body to the no selected command text Fixed an issue where the delete button was showing on dictionaries on the parcel page Added some hint text to the Selected Command panel when there isn't a parcel selected Fixed an issue with the selected command panel wasn't propagating changes Removed the shared dictionary permission for creation Changed permissions for the dictionary create button to check every upload permission Fixed one more permission issue and added a div to support selected command testing Added back in the missing seq adaptation name field Removed unnecessary part of a regex Fixed some styling issues with the selected command panel Fixed an issue where the upload file button wasn't being disabled after upload allow for panel body to show up when SeqJson editor is "hidden" Cleaned up the sequence store and removed all the parcel and parcel id weirdness Fixed an issue when creating a new parcel is another user adds one it reset changes Fixed an issue where parcels never became saveable Moved to a more general seq editor and adaptation Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson Renamed new-sequence-editor dir to sequence-editor Fixed a whole bunch of broken imports Added a helper function to get sequence adaptation globals --------- Co-authored-by: Bryan <[email protected]> Co-authored-by: Chet Joswig <[email protected]> Co-authored-by: joswig <[email protected]>
…ng parcelModified back to false
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
5d1e0ca to
0e9d599
Compare
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
e77e11a to
0e9d599
Compare
duranb
approved these changes
Jul 17, 2024
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
419dd60 to
653a708
Compare
cohansen
force-pushed
the
feature/seq-editor-cleanup
branch
from
653a708 to
55bc3ad
Compare
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Cleanup NumEditor and convert value to a number * Added tooltip support for repeat args * Removed utils.ts again * Cleaned up DictionaryTable so theres only one selection type now * Cleaned up dictionary permissions * Removed aerie-phoenix-wordmark * Disable seqn and seqjson exports when there is no sequence * Added styles to the selected command section * Converted fswCommandArgDefault to use a switch * Renamed parcel to parameter dictionaries * Some more cleanup * Fixed toggling by clicking a row on the parcel page * Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button * Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument * Added st-typography-body to the no selected command text * Fixed an issue where the delete button was showing on dictionaries on the parcel page * Added some hint text to the Selected Command panel when there isn't a parcel selected * Fixed an issue with the selected command panel wasn't propagating changes * Removed the shared dictionary permission for creation * Changed permissions for the dictionary create button to check every upload permission * Fixed one more permission issue and added a div to support selected command testing * Added back in the missing seq adaptation name field * Removed unnecessary part of a regex * Fixed some styling issues with the selected command panel * Fixed an issue where the upload file button wasn't being disabled after upload * allow for panel body to show up when SeqJson editor is "hidden" * Cleaned up the sequence store and removed all the parcel and parcel id weirdness * Fixed an issue when creating a new parcel is another user adds one it reset changes * Fixed an issue where parcels never became saveable * Selected Command styling, fixes, range display * Range display tweak * NumEditor input validation fix * Refactor * Feature/remove sequence lang specifics (#1372) * Moved to a more general seq editor and adaptation * Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time * Fix plan metadata name input reset on snapshot preview (#1358) * fix table action icons staying disabled when no longer in snapshot preview * make table components less plan specific * Add plan JSON export (#1357) * add plan JSON export * Hide plan export button (#1374) * Release v2.15.0 (#1377) Co-authored-by: joswig <[email protected]> * Cleanup NumEditor and convert value to a number Added tooltip support for repeat args Removed utils.ts again Cleaned up DictionaryTable so theres only one selection type now Cleaned up dictionary permissions Removed aerie-phoenix-wordmark Disable seqn and seqjson exports when there is no sequence Added styles to the selected command section Converted fswCommandArgDefault to use a switch Renamed parcel to parameter dictionaries Some more cleanup Fixed toggling by clicking a row on the parcel page Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument Added st-typography-body to the no selected command text Fixed an issue where the delete button was showing on dictionaries on the parcel page Added some hint text to the Selected Command panel when there isn't a parcel selected Fixed an issue with the selected command panel wasn't propagating changes Removed the shared dictionary permission for creation Changed permissions for the dictionary create button to check every upload permission Fixed one more permission issue and added a div to support selected command testing Added back in the missing seq adaptation name field Removed unnecessary part of a regex Fixed some styling issues with the selected command panel Fixed an issue where the upload file button wasn't being disabled after upload allow for panel body to show up when SeqJson editor is "hidden" Cleaned up the sequence store and removed all the parcel and parcel id weirdness Fixed an issue when creating a new parcel is another user adds one it reset changes Fixed an issue where parcels never became saveable Moved to a more general seq editor and adaptation Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson Renamed new-sequence-editor dir to sequence-editor Fixed a whole bunch of broken imports Added a helper function to get sequence adaptation globals --------- Co-authored-by: Bryan <[email protected]> Co-authored-by: Chet Joswig <[email protected]> Co-authored-by: joswig <[email protected]> * Fixed an issue where renaming the parcel and then saving wasn't setting parcelModified back to false * Fixed some tests I broke * Fixed all the to and from seq json unit tests * Fixed an issue where the save button was flickering on the parcel page * Removed unused var * Added a max-width for the sequence editor tooltips --------- Co-authored-by: bduran <[email protected]> Co-authored-by: Aaron Plave <[email protected]> Co-authored-by: Chet Joswig <[email protected]> Co-authored-by: joswig <[email protected]>
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Cleanup NumEditor and convert value to a number * Added tooltip support for repeat args * Removed utils.ts again * Cleaned up DictionaryTable so theres only one selection type now * Cleaned up dictionary permissions * Removed aerie-phoenix-wordmark * Disable seqn and seqjson exports when there is no sequence * Added styles to the selected command section * Converted fswCommandArgDefault to use a switch * Renamed parcel to parameter dictionaries * Some more cleanup * Fixed toggling by clicking a row on the parcel page * Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button * Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument * Added st-typography-body to the no selected command text * Fixed an issue where the delete button was showing on dictionaries on the parcel page * Added some hint text to the Selected Command panel when there isn't a parcel selected * Fixed an issue with the selected command panel wasn't propagating changes * Removed the shared dictionary permission for creation * Changed permissions for the dictionary create button to check every upload permission * Fixed one more permission issue and added a div to support selected command testing * Added back in the missing seq adaptation name field * Removed unnecessary part of a regex * Fixed some styling issues with the selected command panel * Fixed an issue where the upload file button wasn't being disabled after upload * allow for panel body to show up when SeqJson editor is "hidden" * Cleaned up the sequence store and removed all the parcel and parcel id weirdness * Fixed an issue when creating a new parcel is another user adds one it reset changes * Fixed an issue where parcels never became saveable * Selected Command styling, fixes, range display * Range display tweak * NumEditor input validation fix * Refactor * Feature/remove sequence lang specifics (#1372) * Moved to a more general seq editor and adaptation * Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time * Fix plan metadata name input reset on snapshot preview (#1358) * fix table action icons staying disabled when no longer in snapshot preview * make table components less plan specific * Add plan JSON export (#1357) * add plan JSON export * Hide plan export button (#1374) * Release v2.15.0 (#1377) Co-authored-by: joswig <[email protected]> * Cleanup NumEditor and convert value to a number Added tooltip support for repeat args Removed utils.ts again Cleaned up DictionaryTable so theres only one selection type now Cleaned up dictionary permissions Removed aerie-phoenix-wordmark Disable seqn and seqjson exports when there is no sequence Added styles to the selected command section Converted fswCommandArgDefault to use a switch Renamed parcel to parameter dictionaries Some more cleanup Fixed toggling by clicking a row on the parcel page Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument Added st-typography-body to the no selected command text Fixed an issue where the delete button was showing on dictionaries on the parcel page Added some hint text to the Selected Command panel when there isn't a parcel selected Fixed an issue with the selected command panel wasn't propagating changes Removed the shared dictionary permission for creation Changed permissions for the dictionary create button to check every upload permission Fixed one more permission issue and added a div to support selected command testing Added back in the missing seq adaptation name field Removed unnecessary part of a regex Fixed some styling issues with the selected command panel Fixed an issue where the upload file button wasn't being disabled after upload allow for panel body to show up when SeqJson editor is "hidden" Cleaned up the sequence store and removed all the parcel and parcel id weirdness Fixed an issue when creating a new parcel is another user adds one it reset changes Fixed an issue where parcels never became saveable Moved to a more general seq editor and adaptation Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson Renamed new-sequence-editor dir to sequence-editor Fixed a whole bunch of broken imports Added a helper function to get sequence adaptation globals --------- Co-authored-by: Bryan <[email protected]> Co-authored-by: Chet Joswig <[email protected]> Co-authored-by: joswig <[email protected]> * Fixed an issue where renaming the parcel and then saving wasn't setting parcelModified back to false * Fixed some tests I broke * Fixed all the to and from seq json unit tests * Fixed an issue where the save button was flickering on the parcel page * Removed unused var * Added a max-width for the sequence editor tooltips --------- Co-authored-by: bduran <[email protected]> Co-authored-by: Aaron Plave <[email protected]> Co-authored-by: Chet Joswig <[email protected]> Co-authored-by: joswig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses all of the
IN PROGRESStasks in #1291.