Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence form "*Editor" components should dispatch an event rather than invoke a callback setInEditor #1540

Open
Tracked by #1385
duranb opened this issue Nov 6, 2024 · 0 comments
Labels
sequencing Anything related to the sequencing domain

Comments

@duranb
Copy link
Collaborator

duranb commented Nov 6, 2024

Currently the sequence editor's form components invoke a function that's passed in from the parent to affect some state on the parent. The convention that's easier to manage is to instead dispatch events up to the parent component. IMO, the only time that passing in a function is appropriate is if the parent needs to define some functionality for the child component to utilize within.

@duranb duranb added the sequencing Anything related to the sequencing domain label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencing Anything related to the sequencing domain
Projects
None yet
Development

No branches or pull requests

1 participant