-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request form for Amiibo database update. #106
Comments
Can https://www.nintendo.com/store/hardware/amiibo/ be substituted for the links? It's a bit confusing. amiibo.life is an unofficial database, not unlike this one. amiibo.life sources the spreadsheet you maintain, which references amiibo.life, which then needs to be referenced to submit info here. If amiibo.life already has the info being submitted here when it is submitted here, then there is no reason to submit it because you already have it. |
The process typically goes like this:
sometimes someone is able to get the real, accurate NFC data before the amiibo comes out, and in those situations, pull requests are accepted usually. We prefer amiibo.life because it has it's own api for requesting images, it has actual data about what games are supported, and the pages never go down. The Nintendo store takes down pages for amiibo they longer sell or have any stock of, making it a poor choice of reference. |
So, fundamentally, submitting the PRs any time after the official release date is wasted effort. That makes my life easier. |
Bear in mind we also accept PRs anytime for corrections, additional metadata, or improving image quality anytime |
That makes sense. I know it's heresy, but I only got into this whole thing in 2021 (when I took over TagMo) and there isn't much of a welcome package if you weren't here from the beginning. Most, if not all, of the info and resources are from 2017. It's unexpected to see anyone doing much more than the absolute minimum amount of maintenance, so naturally I figured this wasn't much different (not to say that isn't still a lot of work, though). |
Since hardly anyone probably reads much here anyway, here's some history on this project. Basically, I bought an N2 elite at some point (2016 or so) and quickly realized the official app to manage it absolutely sucked. Going online, I realized that the absolute state of all things amiibo was a mess, it was just spoofed bin files everywhere, poor documentation on the ID and what it means, how amiibo work, etc. This resulted in hit-or-miss game compatibility and a plethroa of other problems, like finding bins with save files on them or whatever- quite a disaster. So in the search for something better I met N3Evin (who maintained a now-defunct amiiqo/n2 elite app called amiibitz on an equally now-defunct website.) For a while and I helped him get good data by sourcing dumps of verified real amiibo, but we quickly realized that wasn't really enough to fix the mess everything was publicly- so eventually, N3evin and I put our heads together to make amiiboapi as a public resource- and I got in contact with the amiibo.life guy to help them add NFC info as well. The goal was simple: Get all the correct NFC data publicly available and hopefully prevent the spread of incorrect NFC data. I'm probably glossing over some details here, but for the most part, that's the story. Basically it's just been kinda stagnant since then- partly because I was able to source verified NFC data for literally everything up to a point, even rare stuff like those japanese magazine-exclusive Animal Crossing cards. So, really the database is effectively complete until a new amiibo is released- and then we add it, and it's complete again for like 8 months, since Nintendo has really died down on releasing amiibo left and right, quite unlike the state of things back in 2016, with the amiibo card madness happening constantly. Anyway, we actually do appreciate when PRs are made for newly released stuff, especially if it's not been added on the public repo yet, since often neither me nor n3evin have bothered to do it in a timely fashion. Historically we haven't been to stringent on enforcing the template, it's really just here to prevent people from submitting really bad pulls (hopefully). |
Thanks for the info. Ironically, I got involved because I randomly decided to buy a Switch after they released the second generation and realized that amiibo were running for $50 each, not even remotely portable, and could burn out with use, but the only Android project didn't work with modern phones and had a pretty UI sitting in the PR queue. So here we are... Now that I have a better understanding of how you're doing things, I should be able to step on a few less toes. Thanks again. |
Infomation
Please use the following form when doing a pull request for amiibo database. Do update the
amiibo.json
andgame_info.json
file to prevent error and make sure proper testing had been done. If unsure ongame_info.json
please use the following format attached below and just set the games as empty array, as it will be auto generated. Tick thechecklist
before submitting to ensure you have all the required information.Pull request form
Checklist
game_info.json
had been updated with the corresponding ids.Link to amiibo.life for amiibo
Example for empty game_info
The text was updated successfully, but these errors were encountered: