Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework our class structure and naming to match the official specs #613

Open
oliverklee opened this issue Jun 22, 2024 · 2 comments
Open
Labels
hacktoberfest refactor For PRs that refactor code without changing functionality
Milestone

Comments

@oliverklee
Copy link
Contributor

https://www.w3.org/TR/cssom-1/
https://www.w3.org/TR/css-syntax-3/

We'll probably need to use PHP class aliases and deprecate a lot of things.

@oliverklee oliverklee added the refactor For PRs that refactor code without changing functionality label Jun 22, 2024
@oliverklee oliverklee added this to the 10.0.0 milestone Jun 22, 2024
@JakeQZ
Copy link
Contributor

JakeQZ commented Jun 23, 2024

I'm not so sure.

The referenced documents are not an object model, but a syntax.

Current class hierarchy seems to fit. At least for me. But, yes, please review.

@JakeQZ
Copy link
Contributor

JakeQZ commented Jun 26, 2024

Actually, I think there are some misnomers. E.g. the current Rule\Rule class should be a Declaration or CssDeclaration in some namespace (ref). And the Rule and Property namespaces seem to be transposed from their current official definitions: a 'rule' is an enclosing block; a 'property' is a single value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest refactor For PRs that refactor code without changing functionality
Projects
None yet
Development

No branches or pull requests

2 participants