From b3e93412bb95dc75881bad18299b38ac00a1697f Mon Sep 17 00:00:00 2001
From: Antoniafriedrich <antonia.friedrich@uni-jena.de>
Date: Tue, 22 Oct 2024 15:57:45 +0200
Subject: [PATCH] MIR-1303 Add handling for non-validatable PDF documents

---
 .../config/mir/messages_de.properties         |  8 +-
 .../config/mir/messages_en.properties         |  8 +-
 .../xsl/metadata/mir-pdf-errorbox.xsl         | 83 +++++++++++++------
 3 files changed, 68 insertions(+), 31 deletions(-)

diff --git a/mir-module/src/main/resources/config/mir/messages_de.properties b/mir-module/src/main/resources/config/mir/messages_de.properties
index 9d2b4797a4..072595f597 100644
--- a/mir-module/src/main/resources/config/mir/messages_de.properties
+++ b/mir-module/src/main/resources/config/mir/messages_de.properties
@@ -921,6 +921,8 @@ pdf.errorbox.button.info=Mehr Informationen
 pdf.errorbox.button.download=Herunterladen
 pdf.errorbox.conformity.level=Konformit\u00E4tstufe
 pdf.errorbox.unknown.error=Keine weiteren Informationen!
-pdf.errorbox.clause="Paragraph"
-pdf.errorbox.test="Test"
-pdf.errorbox.specification="Spezifikation"
+pdf.errorbox.clause=Paragraph
+pdf.errorbox.test=Test
+pdf.errorbox.no.conformity=Keine
+pdf.errorbox.specification=Spezifikation
+pdf.errorbox.validationerror.message=Leider konnte dieses Dokument aufgrund eines unbekannten Fehlers nicht validiert werden.
diff --git a/mir-module/src/main/resources/config/mir/messages_en.properties b/mir-module/src/main/resources/config/mir/messages_en.properties
index bed12b0ab5..2d9c64b9a0 100644
--- a/mir-module/src/main/resources/config/mir/messages_en.properties
+++ b/mir-module/src/main/resources/config/mir/messages_en.properties
@@ -873,6 +873,8 @@ pdf.errorbox.button.info=Learn More
 pdf.errorbox.button.download=Download
 pdf.errorbox.conformity.level=Conformity level
 pdf.errorbox.unknown.error=No further information!
-pdf.errorbox.clause="Clause"
-pdf.errorbox.test="Test"
-pdf.errorbox.specification="Specification"
+pdf.errorbox.clause=Clause
+pdf.errorbox.test=Test
+pdf.errorbox.no.conformity=None
+pdf.errorbox.specification=Specification
+pdf.errorbox.validationerror.message=Unfortunately, this document could not be validated due to an unknown error.
diff --git a/mir-module/src/main/resources/xsl/metadata/mir-pdf-errorbox.xsl b/mir-module/src/main/resources/xsl/metadata/mir-pdf-errorbox.xsl
index 7bc72285c3..720e454a43 100644
--- a/mir-module/src/main/resources/xsl/metadata/mir-pdf-errorbox.xsl
+++ b/mir-module/src/main/resources/xsl/metadata/mir-pdf-errorbox.xsl
@@ -15,7 +15,8 @@
         </xsl:variable>
 
         <xsl:choose>
-            <xsl:when test="contains($errorMessages,i18n:translate('pdf.errorbox.clause'))">
+            <xsl:when test="contains($errorMessages,i18n:translate('pdf.errorbox.clause')) or
+                contains($errorMessages,i18n:translate('pdf.errorbox.validationerror.message'))">
                 <div class="container pdf-validation mb-3 px-0" id="accordion">
                     <div class="card-header bg-danger text-white">
                         <div class="list-group list-group-root well p-3">
@@ -32,8 +33,8 @@
                     </div>
                 </div>
             </xsl:when>
-            <xsl:when
-                    test="string-length(normalize-space($errorMessages)) > 0">
+            <xsl:when test="string-length(normalize-space($errorMessages)) >0 and
+            not(contains($errorMessages,i18n:translate('pdf.errorbox.validationerror.message')))">
                 <div class="card-header bg-success text-white mb-3">
                     <div class="list-group list-group-root well p-3">
                         <p class="h5">
@@ -65,6 +66,7 @@
         </xsl:variable>
         <xsl:variable name="badgecolor">
             <xsl:choose>
+                <xsl:when test="failed[@clause='Validation error!']">warning</xsl:when>
                 <xsl:when test="failed">danger</xsl:when>
                 <xsl:otherwise>success</xsl:otherwise>
             </xsl:choose>
@@ -73,44 +75,63 @@
         <div id="{$derivate}{$uniqueFileId}" class="font-weight-bold d-flex list-group list-group-root">
             <a onclick="$('#{$derivate}{$uniqueFileId}cbButton').toggleClass('fa-chevron-right fa-chevron-down');"
                data-toggle="collapse" href="#collapse{$derivate}{$uniqueFileId}"
-               class="text-left d-flex flex-md-row flex-grow-1 list-group-item align-items-center">
+               class="text-left  d-flex  flex-md-row flex-grow-1 list-group-item align-items-center">
                 <i id="{$derivate}{$uniqueFileId}cbButton" class="fa fa-chevron-right ml-auto mr-1"/>
                 <span class="flex-grow-1 font-weight-bold text-break">
                     <xsl:value-of select="$name"/>
                 </span>
                 <span class="badge badge-{$badgecolor} badge-pill align-self-center">
-                    <xsl:value-of select="count(failed)"/>
+                    <xsl:choose>
+                        <xsl:when test="$badgecolor = 'warning'">
+                            !
+                        </xsl:when>
+                        <xsl:otherwise>
+                            <xsl:value-of select="count(failed)"/>
+                        </xsl:otherwise>
+                    </xsl:choose>
                 </span>
             </a>
         </div>
         <ul class="list-group collapse" id="collapse{$derivate}{$uniqueFileId}">
             <li class="list-group-item d-flex flex-column flex-xl-row flex-grow-2 text-break">
-                <p class="flex-grow-1 col-lg-8 align-items-center">
-                    <span class="text-muted pdf-term">
-                        <xsl:value-of select="concat(i18n:translate('pdf.errorbox.conformity.level'),': ')"/>
-                    </span>
-                    <span class="pdf-value">
-                        <xsl:value-of select="concat('PDF/A-',@flavour)"/>
-                    </span>
-                </p>
+                <xsl:choose>
+                    <xsl:when test="failed[@clause='Validation error!']">
+                        <xsl:apply-templates select="failed" mode="displayValidationError"/>
+                    </xsl:when>
+                    <xsl:otherwise>
+                        <p class="flex-grow-1 col-xl-8 align-items-center">
+                            <span class="text-muted pdf-term">
+                                <xsl:value-of select="concat(i18n:translate('pdf.errorbox.conformity.level'),': ')"/>
+                            </span>
+                            <span class="pdf-value">
+                                <xsl:value-of select="concat('PDF/A-',@flavour)"/>
+                            </span>
+                        </p>
+                    </xsl:otherwise>
+                </xsl:choose>
                 <xsl:variable name="downloadLink">
                     <xsl:value-of
-                            select="concat($ServletsBaseURL,'MCRFileNodeServlet/',$derivate,'/',mcrxsl:encodeURIPath(@name))"/>
+                            select="concat($ServletsBaseURL,'MCRFileNodeServlet/',$derivate,'/',
+                            mcrxsl:encodeURIPath(@name))"/>
                 </xsl:variable>
+                <div class="w-100 d-flex align-self-center justify-content-center">
+                    <a role="button" href="{$downloadLink}" target="_blank"
+                       class="btn btn-primary d-flex justify-content-center align-items-center w-100 py-2">
+                        <xsl:value-of select="concat(i18n:translate('pdf.errorbox.button.download'),' ')"/>
+                        <i class="fas fa-download ms-2"></i>
+                    </a>
+                </div>
 
-
-                <a class="btn  btn-primary col" href="{$downloadLink}" target="_blank">
-                    <xsl:value-of select="concat(i18n:translate('pdf.errorbox.button.download'),' ')"/>
-                    <i class="fas fa-download"/>
-                </a>
             </li>
-            <xsl:apply-templates select="failed" mode="displayPdfError"/>
+            <xsl:if test="not(@flavour='0')">
+                <xsl:apply-templates select="failed" mode="displayPdfError"/>
+            </xsl:if>
         </ul>
     </xsl:template>
 
     <xsl:template match="failed" mode="displayPdfError">
         <li class="list-group-item d-flex flex-column flex-xl-row flex-grow-1 text-break">
-            <p class="flex-grow col-lg-8 col-md-9 align-self-center">
+            <p class="flex-grow-1 col-xl-8 align-items-center">
                 <span class="text-muted pdf-term">
                     <xsl:value-of select="concat(i18n:translate('pdf.errorbox.specification'),': ')"/>
                 </span>
@@ -132,10 +153,13 @@
             </p>
             <xsl:choose>
                 <xsl:when test="not(@link)">
-                    <a class="btn btn-info col" role="button" href="{@Link}" target="_blank">
-                        <xsl:value-of select="concat(i18n:translate('pdf.errorbox.button.info'),' ')"/>
-                        <i class="fas fa-external-link-alt"/>
-                    </a>
+                    <div class="w-100 d-flex align-self-center justify-content-center">
+                        <a role="button" href="{@Link}" target="_blank"
+                           class="btn btn-info col d-flex justify-content-center align-items-center w-100 py-2">
+                            <xsl:value-of select="concat(i18n:translate('pdf.errorbox.button.info'),' ')"/>
+                            <i class="fas fa-external-link-alt ms-2"></i>
+                        </a>
+                    </div>
                 </xsl:when>
                 <xsl:otherwise>
                     <div class="text-center alert alert-danger col" role="alert">
@@ -146,6 +170,15 @@
         </li>
     </xsl:template>
 
+    <xsl:template match="failed" mode="displayValidationError">
+        <span class="flex-grow-1 col-xl-8 align-items-center">
+            <p class="text-danger mb-2">
+                <xsl:value-of select="i18n:translate('pdf.errorbox.validationerror.message')"/>
+            </p>
+        </span>
+    </xsl:template>
+
+
     <xsl:template name="pdfError.getFilename">
         <xsl:param name="filePath"/>
         <xsl:variable name="rest-of" select="substring-after($filePath, '/')"/>