Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages with capital letters in their distname end up unpackable by wheel unpack #10

Open
MrMino opened this issue Jul 15, 2021 · 2 comments
Open

Packages with capital letters in their distname end up unpackable by wheel unpack #10

MrMino opened this issue Jul 15, 2021 · 2 comments

Comments

@MrMino
Copy link
Owner

MrMino commented Jul 15, 2021

WheelFile._distinfo_path uses packaging.utils.canonicalize_name, which it shouldn't: it lower-cases the name in the .dist-info prefix, which makes the wheel unrecognizable to wheel unpack and pip:

Missing Django-3.2.5+myversion.dist-info/RECORD file

Found out during working on the snippet in #9.
@MrMino
Copy link
Owner Author

MrMino commented Jul 15, 2021

Actually, the way WheelFile does it right now is the spec-correct way. See https://discuss.python.org/t/clarify-naming-of-dist-info-directories/5565.

@MrMino MrMino mentioned this issue Jul 15, 2021
Closed
@MrMino
Copy link
Owner Author

MrMino commented Jul 15, 2021

Reported in pypa/wheel#411

@MrMino MrMino changed the title Packages with capital letters in their distname end up corrupted Packages with capital letters in their distname end up unpackable by wheel unpack Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrMino