Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Consider returning a default sitStand transform #616

Closed
caseyyee opened this issue Oct 11, 2018 · 5 comments
Closed

Consider returning a default sitStand transform #616

caseyyee opened this issue Oct 11, 2018 · 5 comments
Assignees
Labels
needinfo Further information is requested WebVR/XR
Milestone

Comments

@caseyyee
Copy link
Contributor

Hardware

Oculus Go

Steps to Reproduce

  1. See VRDisplay.stageParameters.sittingToStandingTransform :

image

Current Behavior

Oculus browser returns default sitStand transform, we should consider doing this as well.

Expected Behavior

Not totally sure about this. But I don't feel there is any negative effects to having a default sitStand transform returned. The side effect of not having one is that some content will start at "foot level" if not properly handling the case where one is not present. Though rare, I have seen this in the past. Generally, it seems that it's expected from content creators to handle this case.

Possible Solution

Return sitStand transform.

@avrignaud avrignaud added P2 Fix in the next development iteration v1.1 labels Oct 16, 2018
@larsbergstrom
Copy link

Note that on Wave and Daydream 6DoF platforms, we can provide this natively with real data. On Oculus Go, we just set the height to 1.7m and pass it through.

@avrignaud avrignaud removed the v1.1 label Oct 30, 2018
@larsbergstrom
Copy link

@bluemarvin @MortimerGoro

Did we decide to do anything here? I believe that this would just be for 3DoF / Oculus Go (since IIRC Randall said we get a height for 6DoF platforms). Or should we stick with the current default height for 1.1 and revisit later?

@caseyyee
Copy link
Contributor Author

caseyyee commented Nov 2, 2018

Just to be clear, we don't have a default height at all being returned since the sitStand transform is empty. We should probably return one or pass that through from the Oculus API if there is one provided. I'm guessing this is what Oculus browser does?

@cvan cvan added P3 Backlog and removed P2 Fix in the next development iteration labels Nov 27, 2018
@philip-lamb philip-lamb added this to the v1.2 milestone Mar 9, 2019
@philip-lamb
Copy link
Contributor

@MortimerGoro @bluemarvin I believe this issue has been addressed in the work done for 6 DoF devices. Is that the case? If so, please close this issue.

@philip-lamb philip-lamb added the needinfo Further information is requested label May 8, 2019
@MortimerGoro
Copy link
Contributor

@philip-lamb yes, it was fixed in #1036

@philip-lamb philip-lamb removed P3 Backlog labels May 8, 2019
@cvan cvan modified the milestones: v1.2, v1.1.3 May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needinfo Further information is requested WebVR/XR
Projects
None yet
Development

No branches or pull requests

7 participants