Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Remove dom.vr.require-gesture: false on release #3348

Closed
fernandojsg opened this issue May 7, 2020 · 3 comments · Fixed by #3353
Closed

Remove dom.vr.require-gesture: false on release #3348

fernandojsg opened this issue May 7, 2020 · 3 comments · Fixed by #3353
Assignees
Milestone

Comments

@fernandojsg
Copy link

Configuration

Firefox Reality version: 10 (master)
Firefox Reality build ID: ea7a9e0

Hardware: Oculus Quest

Steps to Reproduce

  1. Visit https://autoenter-xr.glitch.me
  2. It will "auto-enter" XR

Current Behavior

It successfully trigger the XR interstitial to enter XR without requiring user gesture

Expected Behavior

You should not be able to start a XR session without triggering an user gesture (Unless you have the dom.vr.require-gesture set to false.

Possible Solution

Set dom.vr.require-gesture set to true by default on releases.

@bluemarvin
Copy link
Contributor

Something must have changed in Gecko because we only set it if it is in the extras of the intent.

@fernandojsg
Copy link
Author

fernandojsg commented May 8, 2020

I believe @MortimerGoro could have more info on that, he knew this setting was on

@bluemarvin bluemarvin added this to the #10 features milestone May 8, 2020
@bluemarvin
Copy link
Contributor

We can't ship with this enabled, I'll look into today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants