Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

The "Send Tab to Device" prompt is auto dismissed when trying to send a tab from the Hamburger menu after the app is resumed #2329

Closed
Softvision-RemusDranca opened this issue Nov 20, 2019 · 5 comments · Fixed by #2351
Closed

The "Send Tab to Device" prompt is auto dismissed when trying to send a tab from the Hamburger menu after the app is resumed #2329

Softvision-RemusDranca opened this issue Nov 20, 2019 · 5 comments · Fixed by #2351
Assignees
@keianhzo
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone
#7 polish

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

  • Firefox Reality version 7 RC2 (ff64d29)

[Affected Platforms]:

  • Oculus Go - Android 7.1.2
  • Oculus Quest - Android 7.1.1

[Prerequisites]:

  • The Firefox Reality browser is opened.
  • Make sure that the FxA account is logged on the VR device and also on a second device.

[Steps to reproduce]:

  1. Click the "Oculus" button from the controller.
  2. Click the "Resume" button from the prompt displayed.
  3. Click the Hamburger button.
  4. Click the "Send Tab to Device" button from the Hamburger menu.
  5. Observe the "Send Tab to Device" prompt.

[Expected results]:

  • The prompt is displayed and remains displayed.

[Actual results]:

  • The prompt is briefly displayed and after it's auto dismissed.

[Notes]:

  • The issue is reproducible when trying to send a tab after the device exits sleep mode.
  • The issue is also reproducible after reopening the app.
  • This issue is not reproducible if the tab is sent from "View Tabs".
  • The issue is no longer reproducible after trying to send a tab on a second attempt.
  • I was not able to reproduce this issue on the HTC Vive Focus devices.
  • Attached a screen recording of the issue: here.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Nov 20, 2019
@jvonitter jvonitter added this to the #7 polish milestone Nov 20, 2019
@bluemarvin bluemarvin assigned bluemarvin and unassigned bluemarvin Nov 21, 2019
@bluemarvin
Copy link
Contributor

This worked in v7 rc1. Will do a bisect to try and narrow down the commit causing the regression.

@bluemarvin
Copy link
Contributor

Maybe it didn't work in v7 rc1. Still trying to track down the issue.

@bluemarvin
Copy link
Contributor

Looks like it was caused by #2228

@bluemarvin
Copy link
Contributor

Looks like it was caused by this change https://github.com/MozillaReality/FirefoxReality/pull/2228/files#diff-4f3b7fc6e7c2e6cb9d5359555ffe7e67L45-R46

@keianhzo keianhzo mentioned this issue Nov 22, 2019
Merged
@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 7 RC4 (143a88a) installed on the Oculus Go, Quest, HTC Vive Focus and Focus Plus headsets.
Now, the "Send Tab to Device" prompt is not dismissed when trying to send a tab from the Hamburger menu after the app was resumed.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Milestone
#7 polish
Development

Successfully merging a pull request may close this issue.

Fixes UIDialog focus issues MozillaReality/FirefoxReality
6 participants
@bluemarvin @keianhzo @philip-lamb @Softvision-RemusDranca @jvonitter @Softvision-GeluHaiduc