Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

move telemetry computation off client #2030

Closed
2 of 4 tasks
jvonitter opened this issue Oct 21, 2019 · 3 comments · Fixed by #2323
Closed
2 of 4 tasks

move telemetry computation off client #2030

jvonitter opened this issue Oct 21, 2019 · 3 comments · Fixed by #2323
Assignees
Milestone

Comments

@jvonitter
Copy link
Contributor

jvonitter commented Oct 21, 2019

We have too much telemetry computation at the client side. Ideally, we would upload raw data to the data server and do the computation there.

  • examine current telemetry and determine what need to be broken out
  • make those changes client-side
  • update server-side logic so all the queries don't break
  • update wiki and data review as needed

related to #1420

@daoshengmu
Copy link
Contributor

related to #1420

There is no connection with #1420. We are going to fix the telemetry that are made by #1443.

@daoshengmu
Copy link
Contributor

daoshengmu commented Nov 20, 2019

  • Remove curved mode

  • Remove max windows reached

  • Remove long press context

  • Remove tray new window

  • Frequency of window moves by sessions

  • Frequency of window resizes by sessions

  • Move WINDOW_ACTIVE_TIME_PCT percentage computation to the server side

  • Move OPEN_WINDOWS_TIME_PCT percentage computation to the server side

  • Move WINDOWS_OPEN_W_MEAN computation to the server side

@daoshengmu
Copy link
Contributor

@keianhzo It looks like we have bugs here [1] [2]. We should use index[0,1,2] instead of WindowPlacement[Left, Front, Right]. The data are disorder now.

[1]

TelemetryEvent event = TelemetryEvent.create(Category.ACTION, Method.OPEN_WINDOWS_TIME_PCT, Object.WINDOW);
event.extra(Extra.ONE_OPEN_WINDOWS_TIME_PCT, String.valueOf(pcts[WindowPlacement.LEFT.getValue()]));
event.extra(Extra.TWO_OPEN_WINDOWS_TIME_PCT, String.valueOf(pcts[WindowPlacement.FRONT.getValue()]));
event.extra(Extra.THREE_OPEN_WINDOWS_TIME_PCT, String.valueOf(pcts[WindowPlacement.RIGHT.getValue()]));
event.queue();
Log.d(LOGTAG, "[Queue] Open Windows time Pct:");
Log.d(LOGTAG, "\tONE: " + pcts[WindowPlacement.FRONT.getValue()]);
Log.d(LOGTAG, "\tTWO: " + pcts[WindowPlacement.LEFT.getValue()]);
Log.d(LOGTAG, "\tTHREE: " + pcts[WindowPlacement.RIGHT.getValue()]);

[2]
Log.d(LOGTAG, "Placements times (private):");
Log.d(LOGTAG, "\tONE: " + openPrivateWindowsTime[WindowPlacement.FRONT.getValue()]);
Log.d(LOGTAG, "\tTWO: " + openPrivateWindowsTime[WindowPlacement.LEFT.getValue()]);
Log.d(LOGTAG, "\tTHREE: " + openPrivateWindowsTime[WindowPlacement.RIGHT.getValue()]);
Log.d(LOGTAG, "Open Windows Count (private):");
Log.d(LOGTAG, "\tFRONT: " + openPrivateWindows[WindowPlacement.FRONT.getValue()]);
Log.d(LOGTAG, "\tLEFT: " + openPrivateWindows[WindowPlacement.LEFT.getValue()]);
Log.d(LOGTAG, "\tRIGHT: " + openPrivateWindows[WindowPlacement.RIGHT.getValue()]);
} else {
if (from > 0) {
openWindowsTime[from-1] += SystemClock.elapsedRealtime() - openWindowsStartTime[from-1];
openWindowsStartTime[from-1] = 0;
}
if (to > 0) {
openWindows[to-1]++;
openWindowsStartTime[to-1] = SystemClock.elapsedRealtime();
}
Log.d(LOGTAG, "Placements times:");
Log.d(LOGTAG, "\tONE: " + openWindowsTime[WindowPlacement.FRONT.getValue()]);
Log.d(LOGTAG, "\tTWO: " + openWindowsTime[WindowPlacement.LEFT.getValue()]);
Log.d(LOGTAG, "\tTHREE: " + openWindowsTime[WindowPlacement.RIGHT.getValue()]);
Log.d(LOGTAG, "Open Windows Count:");
Log.d(LOGTAG, "\tFRONT: " + openWindows[WindowPlacement.FRONT.getValue()]);
Log.d(LOGTAG, "\tLEFT: " + openWindows[WindowPlacement.LEFT.getValue()]);
Log.d(LOGTAG, "\tRIGHT: " + openWindows[WindowPlacement.RIGHT.getValue()]);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants