From 3db73db963838d3980c52b00368f8c483fdba6b1 Mon Sep 17 00:00:00 2001 From: Jan-Erik Rediger Date: Mon, 16 Dec 2019 11:50:51 +0100 Subject: [PATCH] Rename ping to avoid underscores --- app/metrics.yaml | 14 +++++++------- app/pings.yaml | 2 +- docs/metrics.md | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/app/metrics.yaml b/app/metrics.yaml index 21280023b..cbc50540b 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -16,7 +16,7 @@ distribution: - baseline - events - metrics - - session_end + - session-end bugs: - https://github.com/MozillaReality/FirefoxReality/issues/1420 data_reviews: @@ -30,7 +30,7 @@ url: domains: type: counter send_in_pings: - - session_end + - session-end description: > Counting how many domains are visited in a session. bugs: @@ -44,7 +44,7 @@ url: visits: type: counter send_in_pings: - - session_end + - session-end description: > Counting how many URL links are visited in a session. bugs: @@ -92,7 +92,7 @@ tabs: description: > Number of tabs opened during a session send_in_pings: - - session_end + - session-end labels: - context_menu - tabs_dialog @@ -115,7 +115,7 @@ tabs: description: > Number of tabs activated during a session send_in_pings: - - session_end + - session-end bugs: - https://github.com/MozillaReality/FirefoxReality/issues/1609 data_reviews: @@ -229,7 +229,7 @@ control: description: > Counting how many general windows are opened in a session. send_in_pings: - - session_end + - session-end bugs: - https://github.com/MozillaReality/FirefoxReality/issues/2347 data_reviews: @@ -237,4 +237,4 @@ control: notification_emails: - fxr-telemetry@mozilla.com - dmu@mozilla.com - expires: "2020-05-01" \ No newline at end of file + expires: "2020-05-01" diff --git a/app/pings.yaml b/app/pings.yaml index 67ee75831..528f675c1 100644 --- a/app/pings.yaml +++ b/app/pings.yaml @@ -4,7 +4,7 @@ $schema: moz://mozilla.org/schemas/glean/pings/1-0-0 -session_end: +session-end: description: > This ping is sent at the end of a session (when Firefox Reality switches to the background). We usually send search and UI control metrics at the end of a session. diff --git a/docs/metrics.md b/docs/metrics.md index 0cb45b4ea..dcdf8fc9f 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -10,7 +10,7 @@ This means you might have to go searching through the dependency tree to get a f - [baseline](#baseline) - [events](#events) - [metrics](#metrics) - - [session_end](#session_end) + - [session-end](#session-end) ## baseline @@ -49,7 +49,7 @@ The following metrics are added to the ping: | searches.counts |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |Counting how many searches are queried in a specific search engine. The search engine `identifier`s are used as keys for this metric. |[1](https://github.com/MozillaReality/FirefoxReality/pull/2241#issuecomment-557740258)||2020-05-01 | | url.query_type |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |Counting how many URLs are visited in a day, by input method. |[1](https://github.com/MozillaReality/FirefoxReality/pull/2241#issuecomment-557740258)||2020-05-01 | -## session_end +## session-end This ping is sent at the end of a session (when Firefox Reality switches to the background). We usually send search and UI control metrics at the end of a session. The following metrics are added to the ping: