From ecc03e7ffd51dc1f256db0e1772300445a5caffb Mon Sep 17 00:00:00 2001
From: Arne Kiesewetter <banane9@live.de>
Date: Mon, 26 Aug 2024 17:31:56 +0200
Subject: [PATCH] Add priorities for config sections

---
 MonkeyLoader/Configuration/Config.cs        |  4 ++--
 MonkeyLoader/Configuration/ConfigSection.cs | 10 ++++++++--
 MonkeyLoader/Logging/LoggingConfig.cs       |  3 +++
 MonkeyLoader/Meta/LocationConfigSection.cs  |  3 +++
 MonkeyLoader/NuGet/NuGetConfigSection.cs    |  9 ++++++---
 5 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/MonkeyLoader/Configuration/Config.cs b/MonkeyLoader/Configuration/Config.cs
index 8c58c27..470e4c1 100644
--- a/MonkeyLoader/Configuration/Config.cs
+++ b/MonkeyLoader/Configuration/Config.cs
@@ -29,7 +29,7 @@ public sealed class Config : INestedIdentifiable<IConfigOwner>,
 
         private readonly JObject _loadedConfig;
 
-        private readonly HashSet<ConfigSection> _sections = new();
+        private readonly HashSet<ConfigSection> _sections = [];
 
         /// <summary>
         /// Gets the config keys defined in this configuration.
@@ -62,7 +62,7 @@ public sealed class Config : INestedIdentifiable<IConfigOwner>,
         /// <summary>
         /// Gets all loaded sections of this config.
         /// </summary>
-        public IEnumerable<ConfigSection> Sections => _sections.AsSafeEnumerable();
+        public IEnumerable<ConfigSection> Sections => _sections.OrderByDescending(section => section.Priority).ThenBy(section => section.Name);
 
         /// <summary>
         /// Gets or sets a configuration value for the given key,
diff --git a/MonkeyLoader/Configuration/ConfigSection.cs b/MonkeyLoader/Configuration/ConfigSection.cs
index c427f87..a4ee51b 100644
--- a/MonkeyLoader/Configuration/ConfigSection.cs
+++ b/MonkeyLoader/Configuration/ConfigSection.cs
@@ -21,12 +21,12 @@ namespace MonkeyLoader.Configuration
     /// <remarks>
     /// Use your mod's <see cref="Configuration.Config"/> instance to <see cref="Config.LoadSection{TSection}()">load sections</see>.
     /// </remarks>
-    public abstract class ConfigSection : INestedIdentifiable<Config>, IIdentifiableOwner<ConfigSection, IDefiningConfigKey>
+    public abstract class ConfigSection : INestedIdentifiable<Config>, IIdentifiableOwner<ConfigSection, IDefiningConfigKey>, IPrioritizable
     {
         /// <summary>
         /// Stores the <see cref="IDefiningConfigKey"/>s tracked by this section.
         /// </summary>
-        protected readonly HashSet<IDefiningConfigKey> keys = new();
+        protected readonly HashSet<IDefiningConfigKey> keys = [];
 
         private readonly Lazy<string> _fullId;
 
@@ -84,6 +84,12 @@ public abstract class ConfigSection : INestedIdentifiable<Config>, IIdentifiable
 
         Config INestedIdentifiable<Config>.Parent => Config;
 
+        /// <remarks>
+        /// Controls in which order the sections of a <see cref="Configuration.Config"/> are listed.
+        /// </remarks>
+        /// <inheritdoc/>
+        public virtual int Priority => 0;
+
         /// <summary>
         /// Gets whether this config section is allowed to be saved.<br/>
         /// This can be <c>false</c> if something went wrong while loading it.
diff --git a/MonkeyLoader/Logging/LoggingConfig.cs b/MonkeyLoader/Logging/LoggingConfig.cs
index 9516f8f..4bb30be 100644
--- a/MonkeyLoader/Logging/LoggingConfig.cs
+++ b/MonkeyLoader/Logging/LoggingConfig.cs
@@ -56,6 +56,9 @@ internal set
 
         public LoggingLevel Level => LevelKey;
 
+        /// <inheritdoc/>
+        public override int Priority => 30;
+
         public bool ShouldCleanLogDirectory => ShouldWriteLogFile && FilesToPreserve > 0;
 
         [MemberNotNullWhen(true, nameof(DirectoryPath), nameof(CurrentLogFilePath))]
diff --git a/MonkeyLoader/Meta/LocationConfigSection.cs b/MonkeyLoader/Meta/LocationConfigSection.cs
index 1e8f6d1..8c71e67 100644
--- a/MonkeyLoader/Meta/LocationConfigSection.cs
+++ b/MonkeyLoader/Meta/LocationConfigSection.cs
@@ -59,6 +59,9 @@ public string PatchedAssemblies
             set => PatchedAssembliesKey.SetValue(value, SetEventLabel);
         }
 
+        /// <inheritdoc/>
+        public override int Priority => 20;
+
         /// <inheritdoc/>
         public override Version Version { get; } = new Version(1, 0);
 
diff --git a/MonkeyLoader/NuGet/NuGetConfigSection.cs b/MonkeyLoader/NuGet/NuGetConfigSection.cs
index a75b2af..23a2187 100644
--- a/MonkeyLoader/NuGet/NuGetConfigSection.cs
+++ b/MonkeyLoader/NuGet/NuGetConfigSection.cs
@@ -19,6 +19,9 @@ public sealed class NuGetConfigSection : ConfigSection
         /// <inheritdoc/>
         public override string Description { get; } = "Contains definitions for how to use which NuGet feeds.";
 
+        /// <inheritdoc/>
+        public override string Id { get; } = "NuGet";
+
         /// <summary>
         /// Gets whether checking NuGet feeds to load mod's library dependencies is enabled.
         /// </summary>
@@ -37,9 +40,6 @@ public bool LoadingModsEnabled
             set => Config.SetValue(EnableLoadingModsKey, value);
         }
 
-        /// <inheritdoc/>
-        public override string Id { get; } = "NuGet";
-
         /// <summary>
         /// Gets the NuGet feeds to check for game packs.
         /// </summary>
@@ -67,6 +67,9 @@ public List<NuGetSource> NuGetModSources
             set => Config.SetValue(NuGetModSourcesKey, value);
         }
 
+        /// <inheritdoc/>
+        public override int Priority => 10;
+
         /// <inheritdoc/>
         public override Version Version { get; } = new Version(1, 0);
     }