Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more settings #71

Open
Pyroman2xxx opened this issue Jul 5, 2020 · 3 comments
Open

Need more settings #71

Pyroman2xxx opened this issue Jul 5, 2020 · 3 comments
Labels
settings Extra settings option. Adding this will propably end up in creating a custom settings menu...
Milestone

Comments

@Pyroman2xxx
Copy link

Great mod!

Using version 0.11.0

There are two things that need settings that currently do not have them:

  1. I need a setting to always display the rolls to players. For example, I would like to always show the attack and damage rolls of NPCs to players without needing to click the display (eye) icon each time.
  2. The token name should be GM-only information. I like the token display but it should just be an image for players. I use the Combat Utility Belt 'Enable hide NPC Names' feature and this breaks that. A setting to make the display of NPC token name to players or just be GM information would be very helpful.

Thank you for your work with this mod!

@Moerill
Copy link
Owner

Moerill commented Jul 5, 2020

1 should actually be coupled with the roll mode i think
if someone wants to roll public it should automatically show rolls.
Though the question here: do you mean target name or attacker name?
image
red or blue arrow?

as for 2.. hmmm
i don't think it should be GM only information, at least not always. i'm randomizing names anyway using token mold, so it never bothered me before.
I think this should be dependend on the tokens settings, whether one is allowed to see the name or not.

Not moving both behind settings makes it more flexible for actual play.

@Moerill Moerill added the settings Extra settings option. Adding this will propably end up in creating a custom settings menu... label Jul 5, 2020
@Moerill Moerill added this to the v0.11.1 milestone Jul 5, 2020
@Pyroman2xxx
Copy link
Author

1 should actually be coupled with the roll mode i think
if someone wants to roll public it should automatically show rolls.
Though the question here: do you mean target name or attacker name?
image
red or blue arrow?

as for 2.. hmmm
i don't think it should be GM only information, at least not always. i'm randomizing names anyway using token mold, so it never bothered me before.
I think this should be dependend on the tokens settings, whether one is allowed to see the name or not.

Not moving both behind settings makes it more flexible for actual play.

Thanks for the reply.

For number 1, I would just like to avoid always needing to click the eye icon to display the rolls to players. The way you have it implemented is perfect otherwise.

For number 2, the red arrow is the name that is the culprit. I agree about it not always being GM-only information which is why I suggest a setting to allow it either way. I would prefer it to be GM-only but others will not. I usually have the NPC token name not displayed since I know what they are without it, but it is useful when the PC rolls an attack against an NPC.

@Moerill
Copy link
Owner

Moerill commented Jul 5, 2020

Ok ye, i'll make it dependend on token settings.

So summary:

  1. Automatically show rolled dice results, when "public roll" is selected when attacking

  2. Make Target Name gm only information, depending on the name display of the token.
    If Always/Hover -> Public
    If Owner(Hover) -> GM only
    This way its easy to h ave different settings for different tokens and it replicates the behaviour of the tokens on t he canvas.

This was referenced Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings Extra settings option. Adding this will propably end up in creating a custom settings menu...
Projects
None yet
Development

No branches or pull requests

2 participants