Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a bug? #1

Open
sunnyxiaohu opened this issue Jun 21, 2024 · 1 comment
Open

Is there a bug? #1

sunnyxiaohu opened this issue Jun 21, 2024 · 1 comment

Comments

@sunnyxiaohu
Copy link

Thanks for your wonderful works.
Is there a bug in:
https://github.com/ModelTC/QLLM/blob/main/models/int_llama_layer.py#L291

@Yiman-GO
Copy link

Yiman-GO commented Aug 9, 2024

According to line40, 'attn_output = self.pv_matmul(attn_weights, value_states)' equals to 'attn_output = torch.matmul(attn_weights, value_states)'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants