Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix board files #264

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Fix board files #264

merged 3 commits into from
Nov 3, 2023

Conversation

elral
Copy link
Collaborator

@elral elral commented Oct 25, 2023

Description of changes

Custom Devices are not a basic device, so MF_CUSTOMDEVICE_SUPPORT should be set to 0 or should be just not defined. So #define MF_CUSTOMDEVICE_SUPPORT 1 / #define MF_CUSTOMDEVICE_SUPPORT 2 is deleted in all board.h files and in the platformio.ini file.

In the xyz_custom.ini files this definition is already included to get the custom devices compiled.

/edit: Fixes #263

@elral elral requested a review from DocMoebiuz as a code owner October 25, 2023 20:03
@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

Copy link

github-actions bot commented Nov 1, 2023

Firmware for this pull request:
Firmware.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DocMoebiuz DocMoebiuz merged commit 9bb8036 into MobiFlight:main Nov 3, 2023
1 check passed
@elral elral deleted the fix_board_files branch November 4, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Within boad.h files wrong defines for Custom Devices
2 participants