Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TM1637 memory and code structure improvements #261

Merged
merged 5 commits into from
Oct 21, 2023
Merged

TM1637 memory and code structure improvements #261

merged 5 commits into from
Oct 21, 2023

Conversation

DocMoebiuz
Copy link
Collaborator

@DocMoebiuz DocMoebiuz commented Oct 20, 2023 •
edited
Loading

Description of changes

Fixes #251

Describe changes here

  • Introduced type instead of using the CS pin
  • Memory improvements.

Before (pro micro)

Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [========  ]  77.3% (used 1978 bytes from 2560 bytes)
Flash: [==========]  99.9% (used 28630 bytes from 28672 bytes)

After

Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [========  ]  77.3% (used 1978 bytes from 2560 bytes)
Flash: [==========]  99.1% (used 28422 bytes from 28672 bytes)

@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

@DocMoebiuz DocMoebiuz requested review from elral and GioCC October 20, 2023 19:46
@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

elral
elral approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@elral elral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from my side.

@DocMoebiuz DocMoebiuz requested a review from elral October 21, 2023 14:42
elral
elral approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@elral elral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@DocMoebiuz DocMoebiuz merged commit 2a4a43c into main Oct 21, 2023
1 check passed
@DocMoebiuz DocMoebiuz deleted the tm1637-improvements branch October 21, 2023 14:44
@elral elral mentioned this pull request Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elral elral elral approved these changes

@GioCC GioCC Awaiting requested review from GioCC

Assignees
No one assigned
Labels
development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for displays based on the TM1637 driver
2 participants
@DocMoebiuz @elral