Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certification Validation #3

Open
TSGames opened this issue Mar 3, 2017 · 5 comments
Open

Add Certification Validation #3

TSGames opened this issue Mar 3, 2017 · 5 comments

Comments

@TSGames
Copy link

TSGames commented Mar 3, 2017

I've used this library to successfully publishing a skill in the store. For this, I've added full validation and modified response status to 400 on Exception. Furthermore, I've also reduced the timestamp validation time to 15 seconds, I'm not sure if it's required but with this modification amazon has acceppted the skill. Attached you find my modified Request.php, may you want to push it into the library., I'm too lazy to setup git ;)

Thanks for providing this library and Regards :)

Request.zip

@pattyland
Copy link

Hey, you could simply click on "Fork this project and edit the file"! Than you could submit your changes and create a pull request without installing any git client ;)

@TSGames
Copy link
Author

TSGames commented May 8, 2017

Thanks, I've done so ;)

@pattyland
Copy link

I don't see it right now: https://github.com/MiniCodeMonkey/amazon-alexa-php/pulls

@TSGames
Copy link
Author

TSGames commented May 8, 2017

I forked it away, it says pull requests are not allowed here.

@Philipowitsch
Copy link

Great job! Thanks. Saved me a lot of time.

Only changes necessary for me:

55: $url=getallheaders()["Signaturecertchainurl"];
-> $url=getallheaders()["SignatureCertChainUrl"];

48: $valid&=$url["port"]==443 || $url["port"]==null;
-> $valid&=(!isset($url["port"])) || (isset($url["port"]) && ($url["port"]==443 || $url["port"]==null));

Added above
79: date_default_timezone_set('UTC');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants