From b8f4c1aabcb3f2f5493b60215c18eba894b11585 Mon Sep 17 00:00:00 2001
From: Jephte Abijuru <57417057+jeph864@users.noreply.github.com>
Date: Wed, 26 Apr 2023 16:04:50 +0200
Subject: [PATCH] session management: fix bugs (#47)

* enable proxy access

* temporary fix for server errors

* fix insert statement & enable deleting db tables
---
 classes/class.ilBigBlueButtonConfigGUI.php |  2 +-
 classes/class.ilBigBlueButtonPlugin.php    |  4 ++--
 classes/class.ilBigBlueButtonProtocol.php  | 11 +++++++++--
 3 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/classes/class.ilBigBlueButtonConfigGUI.php b/classes/class.ilBigBlueButtonConfigGUI.php
index 231fef4..bbe7fd3 100755
--- a/classes/class.ilBigBlueButtonConfigGUI.php
+++ b/classes/class.ilBigBlueButtonConfigGUI.php
@@ -180,7 +180,7 @@ public function save()
             $num = $ilDB->numRows($result);
             if ($num == 0) {
                 $ilDB->manipulate("INSERT INTO rep_robj_xbbb_conf ".
-                "(id, svrpublicurl, svrsalt, choose_recording) VALUES (".
+                "(id, svrpublicurl, svrsalt, choose_recording, guestglobalchoose, sess_enable_max_concurrent, enable_userlimit, sess_max_concurrent, sess_msg_concurrent ) VALUES (".
                 $ilDB->quote(1, "integer").",". // id
                 $ilDB->quote($setPublicURL, "text").",". //public url
                 $ilDB->quote($setSalt, "text").",". //salt
diff --git a/classes/class.ilBigBlueButtonPlugin.php b/classes/class.ilBigBlueButtonPlugin.php
index 29a84ae..47a1251 100755
--- a/classes/class.ilBigBlueButtonPlugin.php
+++ b/classes/class.ilBigBlueButtonPlugin.php
@@ -18,11 +18,11 @@ protected function uninstallCustom()
     {
         global $ilDB;
         // removes plugin tables if they exist
-        /* if($ilDB->tableExists('rep_robj_xbbb_data'))
+         if($ilDB->tableExists('rep_robj_xbbb_data'))
          	$ilDB->dropTable('rep_robj_xbbb_data');
 
          if($ilDB->tableExists('rep_robj_xbbb_conf'))
-         	$ilDB->dropTable('rep_robj_xbbb_conf');*/
+         	$ilDB->dropTable('rep_robj_xbbb_conf');
         return true;
     }
 }
diff --git a/classes/class.ilBigBlueButtonProtocol.php b/classes/class.ilBigBlueButtonProtocol.php
index 07d6c56..42b9785 100755
--- a/classes/class.ilBigBlueButtonProtocol.php
+++ b/classes/class.ilBigBlueButtonProtocol.php
@@ -146,8 +146,15 @@ public function isMeetingRecorded($object)
         $meetingID=$object->getBBBId();
         $mPW=$object->getModeratorPwd();
         ;
-        $meetingInfo = $this->bbb->getMeetingInfo(new GetMeetingInfoParameters($meetingID, $mPW));
-        return $meetingInfo->success();
+        $meetingInfo= null;
+        try{
+            $meetingInfo = $this->bbb->getMeetingInfo(new GetMeetingInfoParameters($meetingID, $mPW));
+            return $meetingInfo->success();
+        }catch(Exception $e){
+            return $meetingInfo;
+        }
+        
+       
     }