-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Savestate fixes #214
Draft
ScribbleTAS
wants to merge
24
commits into
MinecraftTAS:develop
Choose a base branch
from
ScribbleTAS:fix/savestates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Savestate fixes #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed spaces in documentation
ScribbleTAS
added
Bug
Something isn't working
Savestates
Issue is related to savestates
labels
Jul 13, 2024
This was
linked to
issues
Jul 13, 2024
Writing this down so I don't forget:
|
The camera angle was omitted, when the previous tick or subtick was the same. However, this creates huge problems with savestates. Now, full ticks will always contain the camera angle, while subticks may be ommitted - Added scheduling to savestate client packet handler
…estate This happens when you load a savestate during playback. To fix this, a new parameter was introduced to the serialiser called `processExtensions`. Setting this to true will prevent loading metadata and filecommands and only get the TickContainers out of the TASfile.
ScribbleTAS
force-pushed
the
fix/savestates
branch
from
July 20, 2024 14:47
65f1609
to
9aeae79
Compare
- Changed DesyncMonitor values from relative to absolute - Added hash to build - Added version to hud
ScribbleTAS
force-pushed
the
fix/savestates
branch
from
July 26, 2024 18:00
5df61e2
to
cc86838
Compare
- Swapped yaw and pitch in InfoHud
- Trying to fix errors with the future task queue during loadstate - Trying to fix a crash with a tickList being out of sync
More weirdness where savestates come from...
|
- More InfoHud changes
- Added WorldServerDuck - Added documentation to savestate mixins
Alright, timing issues seem mostly fixed and I did get the savestates to sync again...
|
- [Events] Added EventWorldRead and EventWorldWrite
- Renamed ChunkHandler to SavestateWorldHandler - Renamed PlayerHandler to SavestatePlayerHandler - Renamed package "modules" to "handlers" - Commented out KTRNG functionality - Moved level saving methods to SavestateWorldHandler - Added documentation
- Split Configuration into ConfigurationRegistry and the Configuration file, which extends AbstractDataFile - Made the ConfigurationRegistry private, so extension modders use their own config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will take a look at all of these issues