Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShulkerBoxBlockEntityMixin - Set INVENTORY_SIZE #110

Closed
BVengo opened this issue Jul 11, 2024 · 2 comments
Closed

ShulkerBoxBlockEntityMixin - Set INVENTORY_SIZE #110

BVengo opened this issue Jul 11, 2024 · 2 comments

Comments

@BVengo
Copy link

BVengo commented Jul 11, 2024

Motivation

I would like easier compatibility with other mods, without them needing to have their own accessors that need to work around this mod.

Description

This mod has the feature to increase the size of shulkers. In doing so, it needs the mixin ShulkerBoxBlockEntityMixin to modify various functions and sizes. The base class ShulkerBoxBlockEntity has a public constant called INVENTORY_SIZE that isn't being set by the mod. I would like to see it set to whatever the current configs allow.

Other information

I'm requesting this because of an issue opened for my own mod Simple Shulker Preview: Issue here.

I'm working with ItemStack objects rather than ShulkerBoxBlockEntity objects, so cannot directly use the size() function that is modified by your mod. Instead, I rely on the public static final int INVENTORY_SIZE;

@wendavid552
Copy link
Collaborator

Sorry that we have neglected it (That constant is from 1.19.4+ but our main project version is 1.18.2).

However this modification could not solve the issue. Our mod is serverside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants