Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if initialise_infra function requires any config changes #61

Open
ejMina226 opened this issue Aug 29, 2023 · 1 comment
Open

Check if initialise_infra function requires any config changes #61

ejMina226 opened this issue Aug 29, 2023 · 1 comment
Assignees

Comments

@ejMina226
Copy link

Check if initialise_infra function requires any config changes

@ejMina226 ejMina226 self-assigned this Aug 29, 2023
@ejMina226
Copy link
Author

We can't remove this as it's in the intf.ml file and is called in the test_executive itself. To minimise changes to the cloud engine we should keep the function as is below. In the GCP case, the function looks like it's just testing all the pods were deployed with nodes in them. Given that we've abstracted away the infrastructure from the test I assume this will now be done in the network runner (e.g. minimina or AWS), so we don't need anything other than a unit returning function, but we will need some process like this in the network runner that basically checks the network is ready to start the nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant