Legacy testing #74
Merged
Legacy testing #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted_transactions field)
piotr-iohk
requested review from
harrysolovay,
joaosreis and
johnmarcou
as code owners
joaosreis
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
LGTM.
P.S.
I think we can also add some more test cases to the block endpoint. We can either try to find some blocks with transactions that would touch the different points on the codebase (maybe add support for coverage as well?), or run the comparison tests for blocks based on indexes and run from index X to X+Y.
Also, regarding the failing tests for the block and account balance endpoints, I was expecting those to fail as I was aware some things were missing when I worked with Harry on them. Let me know if you need help on fixing them.
piotr-iohk
force-pushed
the
legacy-testing
branch
from
96272b2 to
cd6d63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have cherry-picked commits related to legacy testing from #62 and made necessary adjustments for the current
main. (Leaving out the multi network configuration for now.)There are quite a few differences in comparison tests results for
blockandaccount_balanceand I think it is better to handle them in a separate PR as it most likely will include a bit of changes to the code. For now adding some tests for search/transactions into comparison suite, which pass the comparison test.