Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix row offset for large data frames #21

Open
MilesMcBain opened this issue Jan 18, 2024 · 0 comments
Open

Fix row offset for large data frames #21

MilesMcBain opened this issue Jan 18, 2024 · 0 comments

Comments

@MilesMcBain
Copy link
Owner

This is slow for large data frames:

https://github.com/MilesMcBain/paint/blob/6dbbff1ef5b48839dbfbc9ccc8d6490e1bf7d32d/R/paint.R#L49C3-L53C7

Since an unnecessary copy is made before head()

Replacing with index slicing will greatly improve ipaint() performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MilesMcBain