More workarounds for broken clang-tidy check

MikePopoloski · Sep 23, 2023 · e17a9d5 · e17a9d5
1 parent b93ea77
commit e17a9d5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -29,7 +29,6 @@ Checks: >
     -clang-analyzer-core.UndefinedBinaryOperatorResult,
     -clang-analyzer-core.uninitialized.Assign,
     -clang-analyzer-optin.cplusplus.UninitializedObject,
-    -clang-diagnostic-unknown-pragmas,
     -misc-non-private-member-variables-in-classes,
     -misc-no-recursion,
     -misc-const-correctness,

diff --git a/include/slang/parsing/Token.h b/include/slang/parsing/Token.h
@@ -50,7 +50,9 @@ struct SLANG_EXPORT NumericTokenFlags {
 /// character, or a comment.
 class SLANG_EXPORT Trivia {
 private:
-#pragma pack(push, 4)
+#ifndef __clang_analyzer__
+#    pragma pack(push, 4)
+#endif
     struct ShortStringView {
         const char* ptr;
         uint32_t len;
@@ -70,7 +72,9 @@ class SLANG_EXPORT Trivia {
         syntax::SyntaxNode* syntaxNode;
         FullLocation* fullLocation;
     };
-#pragma pack(pop)
+#ifndef __clang_analyzer__
+#    pragma pack(pop)
+#endif
 
     // The vast majority of trivia lives alongside the token it's attached to, so if
     // you want to know its source location just walk backward from the parent location.