Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from daroczig:master #34

Merged
merged 75 commits into from
Aug 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
9fcc700
ability to pass session to log_shiny_input_changes to detect Testing …
m7pr May 14, 2024
101f869
remove session parameter
m7pr May 16, 2024
4e3600a
move session definition before statement verification
m7pr Jun 19, 2024
9799245
simplify message creation
m7pr Jun 19, 2024
93a2c3c
one more session class to omit
m7pr Jun 20, 2024
40534d0
single quotes
daroczig Jul 31, 2024
4a12bc9
WIP: Check inputs of `log_` config setters
hadley Aug 2, 2024
46fe710
`use_tidy_github_actions()`
hadley Aug 2, 2024
6d92b26
Use dev pak to work around buglet
hadley Aug 5, 2024
537ad8d
Improve glue error message
hadley Aug 5, 2024
3f0da4f
Merge commit '8d83a35d90cec6e1d2cdd6918dd6d7b9061bfb11'
hadley Aug 5, 2024
4a91d0e
Test in current process
hadley Aug 5, 2024
2570a78
Fix error and add test
hadley Aug 5, 2024
5a70496
Convert more external tests to snapshot tests
hadley Aug 5, 2024
6f2840d
Skip tests that can't work on windows
hadley Aug 5, 2024
8a3813f
Add some missing skips
hadley Aug 5, 2024
8d988f8
Make it just work on windows?
hadley Aug 5, 2024
c268aa7
Needs a path
hadley Aug 5, 2024
742b5b6
Fix path
hadley Aug 5, 2024
06d1bec
Use snapshots to make it more clear what's being produced
hadley Aug 5, 2024
9e8492a
Drop system() example since it doesn't work on windows
hadley Aug 5, 2024
bb5794a
Improvements to use of `eval()`
hadley Aug 5, 2024
ab6ef3f
Update snapshot & normalize path
hadley Aug 5, 2024
d371db2
Create the temporary files
hadley Aug 6, 2024
dab03cb
Reset output back to stdout
hadley Aug 6, 2024
6272f86
Include some hopefully diagnostic output
hadley Aug 6, 2024
0850cc6
Always use stdout in vignettes
hadley Aug 6, 2024
0dd13fb
More diagnostics
hadley Aug 6, 2024
31cb2b5
More debugging
hadley Aug 6, 2024
c97d34e
Add missing namespace
hadley Aug 6, 2024
6ccad56
More comprehensive logging reset in vignettes
hadley Aug 6, 2024
384fbe4
Remove debugging code
hadley Aug 6, 2024
a648108
Didn't use processx
hadley Aug 6, 2024
fe2eccf
fix tests
m7pr Aug 6, 2024
746997b
Diagnostics for windows
hadley Aug 6, 2024
15922a5
doh
hadley Aug 6, 2024
38dcb23
Remove debugging hooks; move more code to individual tests; simplify …
hadley Aug 6, 2024
2cb71b8
Merged upstream/master into hadley-actions
hadley Aug 6, 2024
a99a097
Now requires R 4.0.0
hadley Aug 6, 2024
151a73b
Merged upstream/master into hadley-check-inputs
hadley Aug 6, 2024
87b02d5
Complete implementation; add tests + news
hadley Aug 6, 2024
66b0f6f
Tweak `log_config_setter` arguments
hadley Aug 6, 2024
f0ba810
Merge pull request #171 from hadley/actions
daroczig Aug 6, 2024
37d2db0
Merge pull request #181 from hadley/log-config-setter-args
daroczig Aug 6, 2024
1951ea8
Merge branch 'master' into pr155
daroczig Aug 6, 2024
d1c7642
update with shiny namespace prefix and related updates
daroczig Aug 6, 2024
42fce7e
Merge branch 'shiny_extensions_alternative' of github.com:m7pr/logger…
daroczig Aug 6, 2024
3ef4b65
Merge pull request #155 from m7pr/shiny_extensions_alternative
daroczig Aug 7, 2024
55bbe80
fix #174 restyle with styler::style_dir
daroczig Aug 7, 2024
7c83c53
transform to md
daroczig Aug 7, 2024
952f7db
split long lines
daroczig Aug 7, 2024
72819f4
disable fn complexity checker
daroczig Aug 7, 2024
57711d6
best practices
daroczig Aug 7, 2024
c901773
long lines
daroczig Aug 7, 2024
ed7ed42
best practices &&
daroczig Aug 7, 2024
20749bd
disable linter on as.loglevel to be consistent with base R naming
daroczig Aug 7, 2024
cee37da
roxygenize test pkg
daroczig Aug 7, 2024
801b88b
rerun roxygen2 after linter updates
daroczig Aug 7, 2024
1ee04a9
set up linter
daroczig Aug 7, 2024
992eb7e
Merge commit '3ef4b650503ac4d1fa2844bfdc15fe373662bf61'
hadley Aug 7, 2024
f6d2b9f
Merged upstream/master into hadley-eval-improvements
hadley Aug 7, 2024
94c068f
Fix bug I introduced in `%except%`
hadley Aug 7, 2024
8d54980
Handle all consistently and test
hadley Aug 7, 2024
e907364
`use_tidy_description()`
hadley Aug 7, 2024
b4b9d92
Merge pull request #186 from daroczig/lint
daroczig Aug 7, 2024
b9d1244
fix lines merged during restyling
daroczig Aug 7, 2024
7a1998c
Merge pull request #189 from hadley/description
daroczig Aug 7, 2024
d00f0ed
Merge pull request #185 from daroczig/restyle
daroczig Aug 7, 2024
f305cab
Merge branch 'master' into pr178
daroczig Aug 7, 2024
a63774a
lint
daroczig Aug 7, 2024
50691dd
double hash for comments on their own line
daroczig Aug 7, 2024
f8855cf
Merge pull request #178 from hadley/eval-improvements
daroczig Aug 7, 2024
c9e0058
Merge branch 'master' into pr170
daroczig Aug 7, 2024
389d660
lint
daroczig Aug 7, 2024
e9d37c2
Merge pull request #170 from hadley/check-inputs
daroczig Aug 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include some hopefully diagnostic output
hadley committed Aug 6, 2024
commit 6272f8656e907bb82475048b363e897392b621e1
3 changes: 2 additions & 1 deletion tests/testthat/test-CRANSKIP-hooks.R
Original file line number Diff line number Diff line change
@@ -18,7 +18,8 @@ eval_outside <- function(expr) {
if (Sys.info()[["sysname"]] == "Windows") {
path <- paste0(path, ".exe")
}
suppressWarnings(system2(path, input, stdout = TRUE, stderr = TRUE))
# suppressWarnings(system2(path, input, stdout = TRUE, stderr = TRUE))
suppressWarnings(system2(path, input))
readLines(output)
}

2 changes: 2 additions & 0 deletions vignettes/Intro.Rmd
Original file line number Diff line number Diff line change
@@ -84,7 +84,9 @@ pander::panderOptions('table.style', 'simple')
```

```{r}
cat("Setting formatter\n", file = stderr())
log_formatter(formatter_pander)
cat(log_formatter(), "\n", file = stderr())
log_info(head(iris))
```