[pull] master from daroczig:master #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…Environment and Namespaces
Use the latest versions of r-lib actions, and flesh out a more complete R version matrix.
* In the formatters, `eval()` wasn't really doing anything because the first argument was evaluated before being passed to `eval()`. If you really did want to evaluate it in the topenv, you'd need `evalq()`, but I think it's better to preserve the existing behaviour and instead simplify the code. * In `with_log_threshold()` and `%except%` we can just rely on lazy evaluation instead of explicit evaluation.
Use `session` in `log_shiny_input_changes` to detect testing environment and utilize namespaces for more informative logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )