[pull] master from daroczig:master #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Convert to .Rmd so we can show live logger output * Minimise the coloured output since the main goal is to show that it exists * Update related work section since most of the GitHub packages haven't been update in ~7 years and I think you can be more explicit about the benefits of logger * Fix a few typos and generally proofread the text. * Hide the links to the pkgdown site on the pkgdown site :)
* Switch to testthat 3 * Turn on parallel testing * Suppress partial match warning in a test. This adds an explict dependency on withr, but you already had that implicitly via testthat and other packages. * Work around (what I'm guessing is) a different in Rscript results on Mac OS.
Please feel to correct any of my descriptions since I'm still getting my head around how logger works (all these PRs are part of my process for learning a new package 😀)
* Don't attach packages at the start of each test file * Don't use `:::` to test internal functions
Use markdown in roxygen2 comments
Polish the README
Testing improvements
Add a basic reference index
`use_dev_version()`
Test style tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )