Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with empty htape file #11

Open
octagonz82 opened this issue Sep 22, 2023 · 0 comments
Open

Issues with empty htape file #11

octagonz82 opened this issue Sep 22, 2023 · 0 comments

Comments

@octagonz82
Copy link
Collaborator

If the htape doesn't give any residue the program doesn't understand how to continue... I suggest creating a no-result object to continue the execution.
In line 76, instead of:
residuals = [__readfeed(inputstr) for inputstr in inputstrs]
residuals = __addmetastable(residuals, inputstr2)
if residuals==[]:
print ("Did not find any residual nuclei. Are you sure this is a correct htape3x output?")
return None
I proposed to include:
if inputstrs == [[]]:
residuals = [[0, [000000], [0.0]]]
else:
residuals = [__readfeed(inputstr) for inputstr in inputstrs]
residuals = __addmetastable(residuals, inputstr2)
if residuals == [[0, [000000], [0.0]]]:
print (f"Did not find any residual nuclei in cell {ncell}. Are you sure this is a correct htape3x output?")

Besides, I would suggest changing every __ to_ to avoid messing with attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant