Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Add Array.chunkBySize docs #273

Merged

Conversation

ErikSchierboom
Copy link
Contributor

@ErikSchierboom ErikSchierboom commented Mar 12, 2017

This PR adds the documentation for Array.chunkBySize.

Refs #184

@orcabot
Copy link
Contributor

orcabot commented Mar 12, 2017

@orcabot
Copy link
Contributor

orcabot commented Mar 12, 2017

Hi! I'm your friendly content validation bot. For this PR to be labeled as ready-to-merge, you'll need at least 2 comments from our designated community approvers containing the magic phrase LGTM (Looks good to me also works, for those of us that are really verbose).

@dend @KevinRansom @cartermp @thedanfernandez @dsyme - please validate this PR.

@dend
Copy link
Contributor

dend commented Mar 12, 2017

⚠️ Validation status: warnings

File Status Preview URL Details
docs/conceptual/collections.array-module-[fsharp].md ⚠️Warning Details
docs/conceptual/array.chunkbysize['t]-function-[fsharp].md ✅Succeeded
docs/conceptual/snippets/fsarrays/snippet75.fs ✅Succeeded

docs/conceptual/collections.array-module-[fsharp].md

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@orcabot
Copy link
Contributor

orcabot commented Mar 12, 2017

@eriawan
Copy link
Contributor

eriawan commented Mar 12, 2017

Hi @dend

CMIIW, any PR to this repo should be no longer valid, right? as far as I know, we are focusing on docs.microsoft.com F# docs.

@ErikSchierboom
Copy link
Contributor Author

@eriawan Oh, sorry about that, but I responded to a Tweet from the visualfsharpteam that tried to enlist help with their documentation and they linked to this repository.

@eriawan
Copy link
Contributor

eriawan commented Mar 12, 2017

@ErikSchierboom no worries 🙂

I know that VisualStudio F# team is tweeting the needs for contribution to F# docs. Please continue your PR to this repo, Erik.
There are still warnings on the PR you have submitted. So I think let's finish your PR on this repo first. I'm sure @dend will be glad to help you to update the docs on MSFT Docs based on your approved PR.

@cartermp
Copy link
Contributor

Actually, this PR is valid. More generally, anything under FSharp.Core is valid because those docs have no yet migrated to docs.microsoft.com. We're in the process of building out a newer and better API Reference browser which dramatically improves the experience today.

@KevinRansom we should be clear that there is a split in documentation for F# at the moment, where API Reference material lives here, and the conceptual F# Guide material loves on docs.microsoft.com.

@cartermp
Copy link
Contributor

LGTM

@eriawan
Copy link
Contributor

eriawan commented Mar 12, 2017

@cartermp ok, I understand now.

I was confused before, because the tweet refers to this repo but there are some docs already in F# section on Docs. We should change the README.MD file to indicate that this repo is for documenting F# API, while F# section on MSFT Docs is for conceptual just like you said.
@ErikSchierboom apologies for any confusion I may have caused. @cartermp has given the clarification.

@ErikSchierboom
Copy link
Contributor Author

@eriawan No problem!

@cartermp cartermp merged commit d88b443 into MicrosoftDocs:master Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants