-
Notifications
You must be signed in to change notification settings - Fork 111
Add Array.chunkBySize docs #273
Add Array.chunkBySize docs #273
Conversation
|
Hi! I'm your friendly content validation bot. For this PR to be labeled as @dend @KevinRansom @cartermp @thedanfernandez @dsyme - please validate this PR. |
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/conceptual/collections.array-module-[fsharp].md | Details | ||
docs/conceptual/array.chunkbysize['t]-function-[fsharp].md | ✅Succeeded | ||
docs/conceptual/snippets/fsarrays/snippet75.fs | ✅Succeeded |
docs/conceptual/collections.array-module-[fsharp].md
- Line 41: [Warning] Invalid file link:(~/array.chunkBySize[&Add current F# release notes #39;t%5D-function-%5Bfsharp%5D.md).
- Line 43: [Warning] Invalid file link:(~/array.comparewith[&Add current F# release notes #39;t%5D-function-%5Bfsharp%5D.md).
- Line 45: [Warning] Invalid file link:(~/array.contains[&Add current F# release notes #39;t%5D-function-%5Bfsharp%5D.md).
- Line 47: [Warning] Invalid file link:(~/array.countby[&Add current F# release notes #39;t,&Add current F# release notes #39;key]-function-[fsharp].md).
- Line 49: [Warning] Invalid file link:(~/array.distinct[&Add current F# release notes #39;t%5D-function-%5Bfsharp%5D.md).
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
|
Hi @dend CMIIW, any PR to this repo should be no longer valid, right? as far as I know, we are focusing on docs.microsoft.com F# docs. |
@eriawan Oh, sorry about that, but I responded to a Tweet from the visualfsharpteam that tried to enlist help with their documentation and they linked to this repository. |
@ErikSchierboom no worries 🙂 I know that VisualStudio F# team is tweeting the needs for contribution to F# docs. Please continue your PR to this repo, Erik. |
Actually, this PR is valid. More generally, anything under FSharp.Core is valid because those docs have no yet migrated to docs.microsoft.com. We're in the process of building out a newer and better API Reference browser which dramatically improves the experience today. @KevinRansom we should be clear that there is a split in documentation for F# at the moment, where API Reference material lives here, and the conceptual F# Guide material loves on docs.microsoft.com. |
LGTM |
@cartermp ok, I understand now. I was confused before, because the tweet refers to this repo but there are some docs already in F# section on Docs. We should change the README.MD file to indicate that this repo is for documenting F# API, while F# section on MSFT Docs is for conceptual just like you said. |
@eriawan No problem! |
This PR adds the documentation for
Array.chunkBySize
.Refs #184