Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant "-r" option of gui command #76

Open
wesleywesley opened this issue Mar 7, 2019 · 2 comments
Open

redundant "-r" option of gui command #76

wesleywesley opened this issue Mar 7, 2019 · 2 comments

Comments

@wesleywesley
Copy link
Contributor

Hi, Guys,

GUI command invoke "switchtec_bwcntr_set_many()" firstly in gui_init() of gui_main(), it clear/reset the bw cntr as a by-product besides setup bw cntr mode (raw/payload).
For this reason, the followed "switchtec_bwcntr_many()" w/ reset is unnecessary.

From the user point of view, "-r" option confuse customer, because w/ or w/o this option, the results is identical. ("-r" option and button press of "r" at runtime are two different things)

Suggesting remove "-r" option gui command from its argument list.

Regard,
Wesley

@lsgunth
Copy link
Collaborator

lsgunth commented Mar 7, 2019

Oh, that's odd. If that's the case there's a bunch of cleanup and confusing code to be done there.

@wesleywesley
Copy link
Contributor Author

If you guys agree remove the -r option, I will try to generate a patch for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants