Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Card Centering #85

Closed
danaiamirali opened this issue Aug 2, 2024 · 8 comments · Fixed by #86
Closed

Project Card Centering #85

danaiamirali opened this issue Aug 2, 2024 · 8 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request

Comments

@danaiamirali
Copy link
Member

Currently, project cards look odd when the project image dimensions are not perfectly lined up with the card dimensions.

This issue is clearly shown when seeing the difference of the two project cards below:

image

There is an uncomfortable amount of padding left below the SoccerNet project title due to the image not being tall enough. If we vertically center the project image/name in the project card component, that should fix the issue - or at least that is my personal proposal to solve the problem.


Also, there is an excessive amount of padding on the right side of the project cards. If we divide the card into two "subfigures" (not sure what the appropriate term is), like shown below, and center the project image/names and the project leads with respect to these "subfigures" that may elevate how everything looks.

image

For all I know, my proposed changes may be a herculean task - please leave comments down below!

@danaiamirali danaiamirali added the enhancement New feature or request label Aug 2, 2024
@Weile-Zheng
Copy link
Contributor

Good issue!

@izzyg770
Copy link
Collaborator

izzyg770 commented Aug 3, 2024

i think this should be fixable in the currentProjectCard component (styles section). i won't be able to get to this until monday, so @neeyam-m and @harishj-um, both of you should look at the styles and see if you can fix it before monday morning?

@harishj-um
Copy link
Contributor

Pushed changes to 85-project-card-centering

Old
image

New
image

@neeyam-m
Copy link
Contributor

neeyam-m commented Aug 5, 2024

I came up with something a little different:
Can push this version as well.

image

@danaiamirali
Copy link
Member Author

@neeyam-m if you can push your changes that would be great since it seems your modification preserves the rounded edges of the project image.

Is there anything we can do about the project lead icons looking off center?

@izzyg770
Copy link
Collaborator

izzyg770 commented Aug 5, 2024

once neeyam pushes his changes, i'll go in tonight to fix the project leads!

@neeyam-m
Copy link
Contributor

neeyam-m commented Aug 5, 2024

just pushed my version to summer24, the project leads column should also be centered vertically

@danaiamirali
Copy link
Member Author

danaiamirali commented Aug 7, 2024

Looks great! Open a PR and we can get this merged

@danaiamirali danaiamirali linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants