-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Card Centering #85
Comments
Good issue! |
i think this should be fixable in the currentProjectCard component (styles section). i won't be able to get to this until monday, so @neeyam-m and @harishj-um, both of you should look at the styles and see if you can fix it before monday morning? |
@neeyam-m if you can push your changes that would be great since it seems your modification preserves the rounded edges of the project image. Is there anything we can do about the project lead icons looking off center? |
once neeyam pushes his changes, i'll go in tonight to fix the project leads! |
just pushed my version to summer24, the project leads column should also be centered vertically |
Looks great! Open a PR and we can get this merged |
Currently, project cards look odd when the project image dimensions are not perfectly lined up with the card dimensions.
This issue is clearly shown when seeing the difference of the two project cards below:
There is an uncomfortable amount of padding left below the SoccerNet project title due to the image not being tall enough. If we vertically center the project image/name in the project card component, that should fix the issue - or at least that is my personal proposal to solve the problem.
Also, there is an excessive amount of padding on the right side of the project cards. If we divide the card into two "subfigures" (not sure what the appropriate term is), like shown below, and center the project image/names and the project leads with respect to these "subfigures" that may elevate how everything looks.
For all I know, my proposed changes may be a herculean task - please leave comments down below!
The text was updated successfully, but these errors were encountered: