Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Addresses #653

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Migrate Addresses #653

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
398c93b
Migrate Addresses
RobBeck1 Sep 16, 2024
153767b
Implementing PR change requests (remove max string limit on AddressPa…
RobBeck1 Sep 17, 2024
ff303df
Merge branch 'master' into CON-2195-Migrate-Addresses
RobBeck1 Sep 20, 2024
73211a1
Applying changes requested in PR
RobBeck1 Sep 20, 2024
5ce22f6
Correcting an error with new AddressResultPage class in monolith and …
RobBeck1 Sep 20, 2024
405a00d
Merge branch 'master' into CON-2195-Migrate-Addresses
RobBeck1 Sep 20, 2024
472dc1f
Regenerated addresses.md to incorporate changes made in the monolith.
RobBeck1 Sep 26, 2024
c18143d
Merge branch 'master' into CON-2195-Migrate-Addresses
jnv Sep 26, 2024
0123cc9
Regenerated addresses.md.
RobBeck1 Nov 15, 2024
4cb34dc
last change: cursor should be optional
RobBeck1 Nov 15, 2024
15bd753
Update _generator/types.yaml
jnv Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _generator/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ tags:
# - accountingitems
- accountnotes
- accounts
# - addresses
- addresses
- agecategories
- availabilityadjustments
# - availabilityblocks
Expand Down
29 changes: 28 additions & 1 deletion _generator/types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ types:
file: accountnotes.md
anchor: account-note-update-classifications
unit:
file: _objects.md
file: vouchers.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in generator, unit behaves strangely since it's a named type but doesn't have any properties, so for some reason the generator always overrides it. 🤔

jnv marked this conversation as resolved.
Show resolved Hide resolved
anchor: unit
multipleaccountnotedeleteparameters:
file: accountnotes.md
Expand Down Expand Up @@ -1022,6 +1022,30 @@ types:
productdeleteparameters:
file: products.md
anchor: product-delete-parameters
addressresult:
file: addresses.md
anchor: addressresult
accountaddress:
file: addresses.md
anchor: account-address
addressfilterparameters:
file: addresses.md
anchor: addressfilterparameters
multipleaddressaddparameters:
file: addresses.md
anchor: multipleaddressaddparameters
addressaddparameters:
file: addresses.md
anchor: account-address-parameters
multipleaddressupdateparameters:
file: addresses.md
anchor: multipleaddressupdateparameters
addressupdateparameters:
file: addresses.md
anchor: account-address-update-parameters
addressdeleteparameters:
file: addresses.md
anchor: addressdeleteparameters
accountresult:
file: accounts.md
anchor: accountresult
Expand Down Expand Up @@ -1100,6 +1124,9 @@ types:
rategroupfilterparameters:
file: rategroups.md
anchor: rategroupfilterparameters
addressresultpage:
file: addresses.md
anchor: addressresultpage
cancellationpolicybyreservationresult:
file: cancellationpolicies.md
anchor: cancellationpolicybyreservationresult
Expand Down
Loading