[F] UpsertUserAll Crash with usernames longer than 8 chars

MewoLab · Nov 14, 2024 · 6c5791b · 6c5791b
1 parent 705b6cc
commit 6c5791b
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/main/java/icu/samnyan/aqua/sega/maimai2/handler/UpsertUserAllHandler.kt b/src/main/java/icu/samnyan/aqua/sega/maimai2/handler/UpsertUserAllHandler.kt
@@ -52,8 +52,15 @@ class UpsertUserAllHandler(
             if (!userName.isValidUsername())
             {
                 // Maybe it's encoded
-                userName = String(userName.toByteArray(Charsets.ISO_8859_1), Charsets.UTF_8)
-                if (!userName.isValidUsername()) 400 - "Invalid username"
+                val decodeUserName = String(userName.toByteArray(Charsets.ISO_8859_1), Charsets.UTF_8)
+                if (userName.isValidUsername()) {
+                    userName = decodeUserName
+                } else {
+                    logger.warn("Invalid username: $userName")
+                    // Maybe it's from some self-made import tools or modified game
+                    // So apply it if user not in database
+                    userName = userData?.userName ?: userName
+                }
             }
         })