Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit when sourcemaps do not exist #13

Open
robbertvancaem opened this issue Jun 13, 2023 · 0 comments
Open

Don't exit when sourcemaps do not exist #13

robbertvancaem opened this issue Jun 13, 2023 · 0 comments

Comments

@robbertvancaem
Copy link
Contributor

Based on this ticket

Currently, in this line we copy the sourcemaps to be included in the tgz. This can lead to a big file, which can exceed the upload limit of 10MB. We could consider two ways of handling this - one not excluding the other;

  1. Increase the upload limit to for example 15MB (outside of the scope of this project). This allows for bigger apps to still have sourcemaps included, which can be handy or even necessary during development and testing on actual devices.
  2. Do not exit/abort the upload action when the sourcemaps are not present. The Lightning-CLI has support for the LNG_BUILD_SOURCEMAP argument, we should probably check if this is set to anything other than true. If that's the case, the files should be allowed to not be there (causing the upload not to fail). If it's set to true, it can be expected that they ARE there, so then it makes sense if the upload/pack action fails

CC: @Thomvl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant