Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove condition to allow 'cosmos' as valid value for verifyingContract field in typed signatures #337

Open
jpuri opened this issue Sep 19, 2024 · 1 comment
Open

fix: remove condition to allow 'cosmos' as valid value for verifyingContract field in typed signatures #337

jpuri opened this issue Sep 19, 2024 · 1 comment
Labels
team-wallet-framework

Comments

@jpuri
Copy link
Contributor

jpuri commented Sep 19, 2024

We have added code to allow cosmos as valid verifyingContract value for typed signatures. The reason for this is to keep support signature signing on cosmos network.

A lot of cosmos dapps use this deprecated sdk with hard coded value of verifyingContract: https://github.com/evmos/ethermint/blob/main/ethereum/eip712/domain.go#L29

Once users stop using this SDK we can remove this hard coded condition.

Ref: MetaMask/metamask-extension#26980
@jpuri jpuri mentioned this issue Sep 19, 2024
Merged
@legobeat
Copy link
Contributor

Perhaps contract verification can be toggled/configured via a constructor parameter in a way that could make this transition non-breaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@desi @jpuri @legobeat