Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the names of the logoURL between DAO & Guild memberships #1503

Open
dysbulic opened this issue Jan 18, 2023 · 0 comments
Open

Align the names of the logoURL between DAO & Guild memberships #1503

dysbulic opened this issue Jan 18, 2023 · 0 comments
Labels
feature request Feature Requests Hasura GraphQL / Hasura related tasks

Comments

@dysbulic
Copy link
Member

What would you like to be added?

In Hasura, DAOs have an avatarURL property that is mapped onto a logoURL entry when returning memberships.

Guilds, however, use just logo to hold the logo property.

Guilds should have a logoURL instead.

Why is this needed?

Consistency in naming is a large part of the glue holding the mammoth pile of complexity that is MyMeta together. Values that hold URLs end in the string "URL".
@dysbulic dysbulic added feature request Feature Requests Hasura GraphQL / Hasura related tasks labels Jan 18, 2023
@dysbulic dysbulic changed the title Align the names of the logo between DAO & Guild memberships Align the names of the logoURL between DAO & Guild memberships Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Feature Requests Hasura GraphQL / Hasura related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dysbulic