Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks! And some problems #4

Open
B100402352 opened this issue Sep 19, 2017 · 1 comment
Open

Thanks! And some problems #4

B100402352 opened this issue Sep 19, 2017 · 1 comment

Comments

@B100402352
Copy link

Thans very much! This library is very strong and helpful for me. And when using this lib, I discover some problems. I expect the totally new version very much. Here are my tips:
1.when connecting two leads, a node id is distributed. So when one node is not connected, the id is -1. The problem is, -1 will be a common id of all leads not connected.That is, these leads are all connected by this id(-1), this is not correct.
2.when connecting two leads, you make the two nodes share one number id. But, related leads are not considerated. They must have the same id as above.
To solve this two problem, I distribute an id for each lead when adding element. When I connect two leads, I Merge this two num using Union-Find-Set.
3. nonLinear() function in InductorElm returns true. i change it to false.
4. voltdiff should be set in CapacitorElm.

Thanks ! Expect the new version!

@B100402352
Copy link
Author

Another quesion, I can't understand why this matrix equations are established. Do you use KCL rule? Expect your reply and some details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant