You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thans very much! This library is very strong and helpful for me. And when using this lib, I discover some problems. I expect the totally new version very much. Here are my tips:
1.when connecting two leads, a node id is distributed. So when one node is not connected, the id is -1. The problem is, -1 will be a common id of all leads not connected.That is, these leads are all connected by this id(-1), this is not correct.
2.when connecting two leads, you make the two nodes share one number id. But, related leads are not considerated. They must have the same id as above.
To solve this two problem, I distribute an id for each lead when adding element. When I connect two leads, I Merge this two num using Union-Find-Set.
3. nonLinear() function in InductorElm returns true. i change it to false.
4. voltdiff should be set in CapacitorElm.
Thanks ! Expect the new version!
The text was updated successfully, but these errors were encountered:
Thans very much! This library is very strong and helpful for me. And when using this lib, I discover some problems. I expect the totally new version very much. Here are my tips:
1.when connecting two leads, a node id is distributed. So when one node is not connected, the id is -1. The problem is, -1 will be a common id of all leads not connected.That is, these leads are all connected by this id(-1), this is not correct.
2.when connecting two leads, you make the two nodes share one number id. But, related leads are not considerated. They must have the same id as above.
To solve this two problem, I distribute an id for each lead when adding element. When I connect two leads, I Merge this two num using Union-Find-Set.
3. nonLinear() function in InductorElm returns true. i change it to false.
4. voltdiff should be set in CapacitorElm.
Thanks ! Expect the new version!
The text was updated successfully, but these errors were encountered: