Has there been a change in Mergify that causes to drop approvals after rebase?

[nixpanic]

Hi!

Over at Ceph-CSI we are big fans of Mergify, thanks 👍

Unfortunately, it seems that there are occasional approvals dropped after a @mergify rebase or automatic rebase before automatic merging. This is very sad, as reviewing changes is one of the main time-consuming tasks of the maintainers.

We have an example at ceph/ceph-csi#2307 (comment)

This most likely started to happen somewhere last week. If there has been an intentional change, we are happy to adjust the configuration. But, of course we also understand that some bugs sneak through, and if that is the case, we can open a GitHub issue with the details shared in this discussion (and more if you tell us what you need).

Thanks!
Niels

[jd]

Hi @nixpanic

This should not happen; we think it's a bug and we'll track it here #2940

Thanks for reporting!

[nixpanic]

Thanks for the reply!

It seems you guys already fixed the issue too, great job 🍰