Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support OAuth #94

Open
pnadolny13 opened this issue Nov 18, 2024 · 6 comments
Open

feat: Support OAuth #94

pnadolny13 opened this issue Nov 18, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python code

Comments

@pnadolny13
Copy link
Collaborator

Currently the tap only supports API tokens https://developer.atlassian.com/cloud/jira/platform/basic-auth-for-rest-apis/#get-an-api-token. We should add support for OAuth.
@pnadolny13 pnadolny13 mentioned this issue Nov 18, 2024
Merged
@edgarrmondragon edgarrmondragon added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python code labels Nov 19, 2024
@imprvhub
Copy link

Hi! I would like to work on this issue. I have experience with Python, APIs and OAuth implementations. I'll follow the OAuth documentation from Atlassian to implement this feature.

@imprvhub
Copy link

imprvhub commented Nov 27, 2024 •
edited
Loading

Can you guys assign me to this issue?

@edgarrmondragon edgarrmondragon self-assigned this Nov 27, 2024
@edgarrmondragon
Copy link
Member

Can you guys assign me to this issue?

Done!

@imprvhub
Copy link

Hi! I see that I'm not assigned to this issue but would still like to contribute. Would it be okay if I work on it and submit a PR? Let me know!

@edgarrmondragon
Copy link
Member

Hi! I see that I'm not assigned to this issue but would still like to contribute. Would it be okay if I work on it and submit a PR? Let me know!

Sorry about that, I've assigned you this time. Of course PRs are welcome regardless 😄

@imprvhub imprvhub mentioned this issue Nov 27, 2024
Closed
@imprvhub
Copy link

@edgarrmondragon PR ready for review

Changes:

Added OAuth2 support
New tests

Let me know if any changes needed. Thanks!

@imprvhub imprvhub removed their assignment Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python code
Projects
MeltanoLabs Overview
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add OAuth2 authentication support imprvhub/tap-jira
3 participants
@edgarrmondragon @pnadolny13 @imprvhub