Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] chore: Bump multus version thick plugin #975

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adrianchiris
Copy link
Collaborator

@adrianchiris adrianchiris commented Jun 19, 2024

  • deploy multus thick plugin. update manifests accordingly
  • use sha256 digest as there is no recent release version
    of multus for now.

Note: we should first update PR to point to a version of multus (preferably a release tag) which supports multiarch (PR1297)

@adrianchiris adrianchiris changed the title Bump multus version chore: Bump multus version Jun 19, 2024
@adrianchiris
Copy link
Collaborator Author

adrianchiris commented Jun 19, 2024

one thing to note: due to the lack of a recent multus release, we use a sha256 digest of a recent commit.

the way i see it we got two options:

  1. request a new release of multus [1]
  2. fork and maintain our own tags like we do with sriov-network-operator.

For the moment thick plugin does not support multiarch will take it with community

[1] k8snetworkplumbingwg/multus-cni#1253

@adrianchiris adrianchiris changed the title chore: Bump multus version [DNM] chore: Bump multus version Jun 19, 2024
- deploy multus thick plugin. update manifests accordingly
- use sha256 digest as there is no recent release version
  of multus for now.

Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9583534824

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 63.608%

Totals Coverage Status
Change from base Build 9579087671: 0.3%
Covered Lines: 3237
Relevant Lines: 5089

💛 - Coveralls

@adrianchiris adrianchiris changed the title [DNM] chore: Bump multus version [DNM] chore: Bump multus version thick plugin Jun 24, 2024
@e0ne e0ne added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold This enhancement is currently on hold pending additional clarification and evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants