Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: Adding maintenance operator charts [WIP] #1191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

task: Adding maintenance operator charts [WIP] #1191

wants to merge 1 commit into from

Conversation

heyvister1
Copy link
Contributor

Adding maintenance operator charts

@heyvister1 heyvister1 added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Nov 26, 2024
@heyvister1 heyvister1 changed the title Adding maintenance operator charts [WIP] task: Adding maintenance operator charts [WIP] Nov 26, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12025369179

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 14 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.007%) to 60.467%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hack/release.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
hack/release.go 1 0.0%
controllers/macvlannetwork_controller.go 2 86.25%
pkg/state/state_ipoib_network.go 4 75.24%
controllers/ipoibnetwork_controller.go 7 77.38%
Totals Coverage Status
Change from base Build 11996301242: 0.007%
Covered Lines: 3365
Relevant Lines: 5565
💛 - Coveralls

rollandf
rollandf reviewed Nov 27, 2024
View reviewed changes
deployment/network-operator/Chart.yaml
- condition: maintenanceOperator.enabled
name: maintenance-operator-chart
repository: ''
version: 0.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be: "0.0.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rollandf rollandf rollandf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
on hold This enhancement is currently on hold pending additional clarification and evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyvister1 @coveralls @rollandf